Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

videoroom: add missing pin parameter to joinSubscriber #48

Merged
merged 1 commit into from
Nov 11, 2024
Merged

videoroom: add missing pin parameter to joinSubscriber #48

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/plugins/videoroom-plugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -936,9 +936,10 @@ class VideoRoomHandle extends Handle {
* @param {boolean} [params.autoupdate] - [multistream] Whether a new SDP offer is sent automatically when a subscribed publisher leaves
* @param {boolean} [params.use_msid] - [multistream] Whether subscriptions should include an msid that references the publisher
* @param {string} [params.token] - The optional token needed
* @param {string} [params.pin] - The optional password required to join the room
* @returns {Promise<module:videoroom-plugin~VIDEOROOM_EVENT_SUB_JOINED>}
*/
async joinSubscriber({ room, feed, audio, video, data, private_id, sc_substream_layer, sc_substream_fallback_ms, sc_temporal_layers, streams, autoupdate, use_msid, token }) {
async joinSubscriber({ room, feed, audio, video, data, private_id, sc_substream_layer, sc_substream_fallback_ms, sc_temporal_layers, streams, autoupdate, use_msid, token, pin }) {
const body = {
request: REQUEST_JOIN,
ptype: PTYPE_LISTENER,
Expand All @@ -960,6 +961,7 @@ class VideoRoomHandle extends Handle {
}
if (typeof private_id === 'number') body.private_id = private_id;
if (typeof token === 'string') body.token = token;
if (typeof pin === 'string') body.pin = pin;

/* [multistream] */
if (typeof autoupdate === 'boolean') body.autoupdate = autoupdate;
Expand Down
Loading