Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add missing keyframe parameter to videoroom configure #44

Merged
merged 1 commit into from
Jul 26, 2024
Merged

Add missing keyframe parameter to videoroom configure #44

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 3 additions & 1 deletion src/plugins/videoroom-plugin.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -765,9 +765,10 @@ class VideoRoomHandle extends Handle {
* @param {number} [params.sc_temporal_layers] - Temporal layers to receive (0-2), in case VP8 simulcasting is enabled (subscribers only)
* @param {boolean} [params.e2ee] - True to notify end-to-end encryption for this connection
* @param {RTCSessionDescription} [params.jsep] - The JSEP offer (publishers only)
* @param {boolean} [params.keyframe] - True to request a keyframe (publishers only)
* @returns {Promise<module:videoroom-plugin~VIDEOROOM_EVENT_CONFIGURED>}
*/
async configure({ audio, video, data, bitrate, record, filename, display, restart, update, streams, descriptions, sc_substream_layer, sc_substream_fallback_ms, sc_temporal_layers, e2ee, jsep }) {
async configure({ audio, video, data, bitrate, record, filename, display, restart, update, streams, descriptions, sc_substream_layer, sc_substream_fallback_ms, sc_temporal_layers, e2ee, jsep, keyframe }) {
const body = {
request: REQUEST_CONFIGURE,
};
Expand All @@ -792,6 +793,7 @@ class VideoRoomHandle extends Handle {
if (typeof restart === 'boolean') body.restart = restart;
if (typeof update === 'boolean') body.update = update;
if (typeof e2ee === 'boolean' && jsep) jsep.e2ee = e2ee;
if (typeof keyframe === 'boolean') body.keyframe = keyframe;

/* [multistream] */
if (descriptions && Array.isArray(descriptions)) body.descriptions = descriptions;
Expand Down
Loading