Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

(dnm) Enketo changes on 3.x architecture (#7821) #7835

Closed
wants to merge 28 commits into from

Conversation

jkuester
Copy link
Contributor

@jkuester jkuester commented Oct 5, 2022

Cherrypicked the following on top of the 3.17.x branch:

License

The software is provided under AGPL-3.0. Contributions to this project are accepted under the same license.

m5r and others added 27 commits July 25, 2022 17:35
This PR adds a button to the users admin page to create users in bulk from a CSV file.

Co-authored-by: m5r <[email protected]>
Co-authored-by: Jennifer Q <[email protected]>
Co-authored-by: Ashley <[email protected]>
Co-authored-by: mrjones-plip <[email protected]>
Co-authored-by: Njuguna Ndung'u <[email protected]>
… text overflow (#7681)

Ticket: #6028 

This commit:
- fixes the display the the header of Task, Contact and Report tabs when the title is too long for mobile view.
- modifies the text overflow css property to apply ellipsis if the title runs over
- changes/removes old code that was clipping the end of the title when the title does not fit into header of mobile view
Tickets: #7721

This commit:
- Enables action's button labels in small font size (same as tab's label)
- Fixes fa-stack icon positioning by making it same height as the other icons in the action bar.
This is a cherry pick of 4382617

7653 - Reports filter redesign (#7696)
Ticket: #7653

This commit:
- Adds 2 new components: a filter that displays on the right side of the report's screen, and an actions bar that contains a search input, a button to open the filter and a button to clear all filters.
- Updates the layout and style classes of: reports, reports detail, reports edit and add, actions-bar component. This is to insert the filter as a sidebar.
- Updates html and styles of the search input, form filter, place filter, date range filter and status filter components.
- Refactored existing filter components to support both old and new designs
- Fixes a current issue affecting place filter: if a child place was already selected, and the user selects the parent place, it was unselecting the child. The expected behaviour is to select the parent and all its children. 
- Fixes a current issue when logging telemetry: when a filter is applied, then cleared individually by clicking "clear", telemetry will keep logging the filter as if it was still in use. The expected behaviour is to not log filters with no selected criteria. 
- Fixes a current issue affecting both old and new filter, when select mode is on and some reports are selected, [it shouldn’t let the user filter or search](#1000 (comment))
- Adds a new permission (`can_view_old_reports_filter `) to turn on the old filter design, admin user can always see the new filter.
- Refactors existing related e2e tests.
- Refactors tour to skip the new filter design only (a decision taken in Care Team)
- Adds a validation message when the "To" date field is before than "From" date field in date range filter.
This change makes npm install `grunt-contrib-watch` and `openrosa-formlist` from github over https to avoid running into a timeout error trying to run `git ls-remote`
Ticket: #6215

This commit:
- Adds checks to can_edit permission in every endpoint that writes in medic db.
- Adds mmAuth directory in action buttons across the app to check can_edit permission and prevent creating docs in local since the user won't be able to sync those in medic db.
- Adds AppRouteGuardProvider in contacts, reports and tasks routings to check for the same permission and prevent navigation to pages that adds documents to medic db.
Co-authored-by: m5r <[email protected]>

(cherry picked from commit d0b8dc9)
This commit adds a third line of text to tasks to display the additional contextual information.
This new line of text should display breadcrumbs showing where the person/place the task is about belongs to.
The functionality should match how we display breadcrumbs elsewhere on the app.
Co-authored-by: Joshua Kuestersteffen <[email protected]>
Co-authored-by: Jennifer Q <[email protected]>

(cherry picked from commit 2a25f87)
(cherry picked from commit cde05fc)
#7421

(cherry picked from commit 52605ac)
@garethbowen
Copy link
Member

@jkuester Can we close this now? If we need to make any more changes we can update the branch and make a new PR.

@jkuester
Copy link
Contributor Author

No longer needed!

@jkuester jkuester closed this Feb 15, 2024
@jkuester jkuester deleted the enketo_upgrade_3.x branch February 15, 2024 21:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants