-
-
Notifications
You must be signed in to change notification settings - Fork 51
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
FEAT: added eCHIS Kenya Training & Testing Instances & updated branding #375
Open
karimkkanji
wants to merge
3
commits into
medic:master
Choose a base branch
from
moh-kenya:feat/moh-kenya-echis-training
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from all commits
Commits
Show all changes
3 commits
Select commit
Hold shift + click to select a range
File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -291,6 +291,32 @@ jobs: | |
ANDROID_KEYSTORE_PASSWORD: ${{ secrets.ANDROID_KEYSTORE_PASSWORD_MOH_KENYA_ECHIS }} | ||
ANDROID_KEY_PASSWORD: ${{ secrets.ANDROID_KEY_PASSWORD_MOH_KENYA_ECHIS }} | ||
|
||
- name: Unpack secrets chis_kenya | ||
env: | ||
ANDROID_SECRETS_KEY: ${{ secrets.ANDROID_SECRETS_KEY_CHIS_KENYA }} | ||
ANDROID_SECRETS_IV: ${{ secrets.ANDROID_SECRETS_IV_CHIS_KENYA }} | ||
run: make org=chis_kenya keydec | ||
|
||
- name: Assemble chis_kenya | ||
uses: maierj/[email protected] | ||
with: | ||
lane: build | ||
options: '{ "flavor": "chis_kenya" }' | ||
env: | ||
ANDROID_KEYSTORE_PATH: chis_kenya.keystore | ||
ANDROID_KEYSTORE_PASSWORD: ${{ secrets.ANDROID_KEYSTORE_PASSWORD_CHIS_KENYA }} | ||
ANDROID_KEY_PASSWORD: ${{ secrets.ANDROID_KEY_PASSWORD_CHIS_KENYA }} | ||
|
||
- name: Bundle chis_kenya | ||
uses: maierj/[email protected] | ||
with: | ||
lane: bundle | ||
options: '{ "flavor": "chis_kenya" }' | ||
env: | ||
ANDROID_KEYSTORE_PATH: chis_kenya.keystore | ||
ANDROID_KEYSTORE_PASSWORD: ${{ secrets.ANDROID_KEYSTORE_PASSWORD_CHIS_KENYA }} | ||
ANDROID_KEY_PASSWORD: ${{ secrets.ANDROID_KEY_PASSWORD_CHIS_KENYA }} | ||
|
||
- name: Assemble chis_ne | ||
uses: maierj/[email protected] | ||
with: | ||
|
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,67 @@ | ||
<?xml version="1.0" encoding="utf-8"?> | ||
<manifest xmlns:android="http://schemas.android.com/apk/res/android" | ||
xmlns:tools="http://schemas.android.com/tools"> | ||
|
||
<uses-permission android:name="android.permission.READ_EXTERNAL_STORAGE" tools:node="remove" /> | ||
|
||
<application> | ||
<activity android:name="AppUrlIntentActivity" | ||
android:launchMode="singleInstance" | ||
android:exported="true"> | ||
<intent-filter android:autoVerify="true"> | ||
<action android:name="android.intent.action.VIEW" /> | ||
<category android:name="android.intent.category.DEFAULT" /> | ||
<category android:name="android.intent.category.BROWSABLE" /> | ||
|
||
<data android:scheme="https" android:host="migori-echis.health.go.ke" android:pathPattern=".*"/> | ||
<data android:scheme="https" android:host="kisumu-echis.health.go.ke" android:pathPattern=".*"/> | ||
<data android:scheme="https" android:host="nyeri-echis.health.go.ke" android:pathPattern=".*"/> | ||
<data android:scheme="https" android:host="kilifi-echis.health.go.ke" android:pathPattern=".*"/> | ||
<data android:scheme="https" android:host="machakos-echis.health.go.ke" android:pathPattern=".*"/> | ||
<data android:scheme="https" android:host="garissa-echis.health.go.ke" android:pathPattern=".*"/> | ||
<data android:scheme="https" android:host="nakuru-echis.health.go.ke" android:pathPattern=".*"/> | ||
<data android:scheme="https" android:host="isiolo-echis.health.go.ke" android:pathPattern=".*"/> | ||
<data android:scheme="https" android:host="nairobi-echis.health.go.ke" android:pathPattern=".*"/> | ||
<data android:scheme="https" android:host="turkana-echis.health.go.ke" android:pathPattern=".*"/> | ||
<data android:scheme="https" android:host="kakamega-echis.health.go.ke" android:pathPattern=".*"/> | ||
<data android:scheme="https" android:host="vihiga-echis.health.go.ke" android:pathPattern=".*"/> | ||
<data android:scheme="https" android:host="kitui-echis.health.go.ke" android:pathPattern=".*"/> | ||
<data android:scheme="https" android:host="uasingishu-echis.health.go.ke" android:pathPattern=".*"/> | ||
|
||
<data android:scheme="https" android:host="baringo.echis.go.ke" android:pathPattern=".*"/> | ||
<data android:scheme="https" android:host="bomet.echis.go.ke" android:pathPattern=".*"/> | ||
<data android:scheme="https" android:host="bungoma.echis.go.ke" android:pathPattern=".*"/> | ||
<data android:scheme="https" android:host="busia.echis.go.ke" android:pathPattern=".*"/> | ||
<data android:scheme="https" android:host="elgeyomarakwet.echis.go.ke" android:pathPattern=".*"/> | ||
<data android:scheme="https" android:host="embu.echis.go.ke" android:pathPattern=".*"/> | ||
<data android:scheme="https" android:host="homabay.echis.go.ke" android:pathPattern=".*"/> | ||
<data android:scheme="https" android:host="kajiado.echis.go.ke" android:pathPattern=".*"/> | ||
<data android:scheme="https" android:host="kericho.echis.go.ke" android:pathPattern=".*"/> | ||
<data android:scheme="https" android:host="kiambu.echis.go.ke" android:pathPattern=".*"/> | ||
<data android:scheme="https" android:host="kirinyaga.echis.go.ke" android:pathPattern=".*"/> | ||
<data android:scheme="https" android:host="kisii.echis.go.ke" android:pathPattern=".*"/> | ||
<data android:scheme="https" android:host="kwale.echis.go.ke" android:pathPattern=".*"/> | ||
<data android:scheme="https" android:host="laikipia.echis.go.ke" android:pathPattern=".*"/> | ||
<data android:scheme="https" android:host="lamu.echis.go.ke" android:pathPattern=".*"/> | ||
<data android:scheme="https" android:host="makueni.echis.go.ke" android:pathPattern=".*"/> | ||
<data android:scheme="https" android:host="mandera.echis.go.ke" android:pathPattern=".*"/> | ||
<data android:scheme="https" android:host="marsabit.echis.go.ke" android:pathPattern=".*"/> | ||
<data android:scheme="https" android:host="meru.echis.go.ke" android:pathPattern=".*"/> | ||
<data android:scheme="https" android:host="mombasa.echis.go.ke" android:pathPattern=".*"/> | ||
<data android:scheme="https" android:host="muranga.echis.go.ke" android:pathPattern=".*"/> | ||
<data android:scheme="https" android:host="nandi.echis.go.ke" android:pathPattern=".*"/> | ||
<data android:scheme="https" android:host="narok.echis.go.ke" android:pathPattern=".*"/> | ||
<data android:scheme="https" android:host="nyamira.echis.go.ke" android:pathPattern=".*"/> | ||
<data android:scheme="https" android:host="nyandarua.echis.go.ke" android:pathPattern=".*"/> | ||
<data android:scheme="https" android:host="samburu.echis.go.ke" android:pathPattern=".*"/> | ||
<data android:scheme="https" android:host="siaya.echis.go.ke" android:pathPattern=".*"/> | ||
<data android:scheme="https" android:host="taitataveta.echis.go.ke" android:pathPattern=".*"/> | ||
<data android:scheme="https" android:host="tanariver.echis.go.ke" android:pathPattern=".*"/> | ||
<data android:scheme="https" android:host="tharakanithi.echis.go.ke" android:pathPattern=".*"/> | ||
<data android:scheme="https" android:host="transnzoia.echis.go.ke" android:pathPattern=".*"/> | ||
<data android:scheme="https" android:host="wajir.echis.go.ke" android:pathPattern=".*"/> | ||
<data android:scheme="https" android:host="westpokot.echis.go.ke" android:pathPattern=".*"/> | ||
</intent-filter> | ||
</activity> | ||
</application> | ||
</manifest> |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,74 @@ | ||
<?xml version="1.0" encoding="utf-8"?> | ||
<vector | ||
android:height="108dp" | ||
android:width="108dp" | ||
android:viewportHeight="108" | ||
android:viewportWidth="108" | ||
xmlns:android="http://schemas.android.com/apk/res/android"> | ||
<path android:fillColor="#3DDC84" | ||
android:pathData="M0,0h108v108h-108z"/> | ||
<path android:fillColor="#00000000" android:pathData="M9,0L9,108" | ||
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/> | ||
<path android:fillColor="#00000000" android:pathData="M19,0L19,108" | ||
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/> | ||
<path android:fillColor="#00000000" android:pathData="M29,0L29,108" | ||
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/> | ||
<path android:fillColor="#00000000" android:pathData="M39,0L39,108" | ||
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/> | ||
<path android:fillColor="#00000000" android:pathData="M49,0L49,108" | ||
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/> | ||
<path android:fillColor="#00000000" android:pathData="M59,0L59,108" | ||
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/> | ||
<path android:fillColor="#00000000" android:pathData="M69,0L69,108" | ||
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/> | ||
<path android:fillColor="#00000000" android:pathData="M79,0L79,108" | ||
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/> | ||
<path android:fillColor="#00000000" android:pathData="M89,0L89,108" | ||
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/> | ||
<path android:fillColor="#00000000" android:pathData="M99,0L99,108" | ||
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/> | ||
<path android:fillColor="#00000000" android:pathData="M0,9L108,9" | ||
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/> | ||
<path android:fillColor="#00000000" android:pathData="M0,19L108,19" | ||
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/> | ||
<path android:fillColor="#00000000" android:pathData="M0,29L108,29" | ||
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/> | ||
<path android:fillColor="#00000000" android:pathData="M0,39L108,39" | ||
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/> | ||
<path android:fillColor="#00000000" android:pathData="M0,49L108,49" | ||
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/> | ||
<path android:fillColor="#00000000" android:pathData="M0,59L108,59" | ||
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/> | ||
<path android:fillColor="#00000000" android:pathData="M0,69L108,69" | ||
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/> | ||
<path android:fillColor="#00000000" android:pathData="M0,79L108,79" | ||
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/> | ||
<path android:fillColor="#00000000" android:pathData="M0,89L108,89" | ||
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/> | ||
<path android:fillColor="#00000000" android:pathData="M0,99L108,99" | ||
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/> | ||
<path android:fillColor="#00000000" android:pathData="M19,29L89,29" | ||
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/> | ||
<path android:fillColor="#00000000" android:pathData="M19,39L89,39" | ||
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/> | ||
<path android:fillColor="#00000000" android:pathData="M19,49L89,49" | ||
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/> | ||
<path android:fillColor="#00000000" android:pathData="M19,59L89,59" | ||
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/> | ||
<path android:fillColor="#00000000" android:pathData="M19,69L89,69" | ||
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/> | ||
<path android:fillColor="#00000000" android:pathData="M19,79L89,79" | ||
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/> | ||
<path android:fillColor="#00000000" android:pathData="M29,19L29,89" | ||
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/> | ||
<path android:fillColor="#00000000" android:pathData="M39,19L39,89" | ||
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/> | ||
<path android:fillColor="#00000000" android:pathData="M49,19L49,89" | ||
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/> | ||
<path android:fillColor="#00000000" android:pathData="M59,19L59,89" | ||
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/> | ||
<path android:fillColor="#00000000" android:pathData="M69,19L69,89" | ||
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/> | ||
<path android:fillColor="#00000000" android:pathData="M79,19L79,89" | ||
android:strokeColor="#33FFFFFF" android:strokeWidth="0.8"/> | ||
</vector> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,6 @@ | ||
<?xml version="1.0" encoding="utf-8"?> | ||
<adaptive-icon xmlns:android="http://schemas.android.com/apk/res/android"> | ||
<background android:drawable="@mipmap/ic_launcher_background"/> | ||
<foreground android:drawable="@mipmap/ic_launcher_foreground"/> | ||
<monochrome android:drawable="@mipmap/ic_launcher_monochrome"/> | ||
</adaptive-icon> |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
<?xml version="1.0" encoding="utf-8"?> | ||
<resources> | ||
<string name="app_name">eCHIS Kenya (Training)</string> | ||
<bool name="allowCustomHosts">False</bool> | ||
</resources> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,7 @@ | ||
<?xml version="1.0" encoding="utf-8"?> | ||
<instances xmlns:android="http://schemas.android.com/apk/res/android"> | ||
<instance name="eCHIS Training 1">https://chis-training.health.go.ke</instance> | ||
<instance name="eCHIS Training 2">https://chis-training-2.health.go.ke</instance> | ||
<instance name="eCHIS Training 3">https://chis-training-3.health.go.ke</instance> | ||
<instance name="eCHIS Testing">https://chis-4-testing.health.go.ke</instance> | ||
</instances> |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,6 @@ | ||
<?xml version="1.0" encoding="utf-8"?> | ||
<adaptive-icon xmlns:android="http://schemas.android.com/apk/res/android"> | ||
<background android:drawable="@drawable/ic_launcher_background"/> | ||
<foreground android:drawable="@mipmap/ic_launcher_foreground"/> | ||
</adaptive-icon> | ||
<background android:drawable="@mipmap/ic_launcher_background"/> | ||
<foreground android:drawable="@mipmap/ic_launcher_foreground"/> | ||
<monochrome android:drawable="@mipmap/ic_launcher_monochrome"/> | ||
</adaptive-icon> |
4 changes: 2 additions & 2 deletions
4
src/moh_kenya_echis/res/mipmap-anydpi-v26/ic_launcher_round.xml
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -1,5 +1,5 @@ | ||
<?xml version="1.0" encoding="utf-8"?> | ||
<adaptive-icon xmlns:android="http://schemas.android.com/apk/res/android"> | ||
<background android:drawable="@drawable/ic_launcher_background"/> | ||
<background android:drawable="@color/ic_launcher_background"/> | ||
<foreground android:drawable="@mipmap/ic_launcher_foreground"/> | ||
</adaptive-icon> | ||
</adaptive-icon> |
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Binary file modified
BIN
-20.8 KB
(47%)
src/moh_kenya_echis/res/mipmap-hdpi/ic_launcher_foreground.png
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Loading
Sorry, something went wrong. Reload?
Sorry, we cannot display this file.
Sorry, this file is invalid so it cannot be displayed.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Binary file modified
BIN
-19.2 KB
(34%)
src/moh_kenya_echis/res/mipmap-mdpi/ic_launcher_foreground.png
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Binary file modified
BIN
-23.8 KB
(56%)
src/moh_kenya_echis/res/mipmap-xhdpi/ic_launcher_foreground.png
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Binary file modified
BIN
-36.1 KB
(60%)
src/moh_kenya_echis/res/mipmap-xxhdpi/ic_launcher_foreground.png
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Oops, something went wrong.
Binary file modified
BIN
-44.7 KB
(66%)
src/moh_kenya_echis/res/mipmap-xxxhdpi/ic_launcher_foreground.png
Oops, something went wrong.
Oops, something went wrong.
Binary file modified
BIN
-5.63 KB
(89%)
src/moh_kenya_echis/res/mipmap-xxxhdpi/ic_launcher_round.png
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Curious naming for this instance as there are no testing 1-3 instances. It seems the intention was to continue naming according to training instance sequence.