MBS-8702: Improve caching #93
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sh-csg
force-pushed
the
MBS-8702-Improve-caching
branch
3 times, most recently
from
3500067 to
687e7db
Compare
sh-csg
force-pushed
the
MBS-8702-Improve-caching
branch
from
687e7db to
9ba6ca0
Compare
sh-csg
force-pushed
the
MBS-8702-Improve-caching
branch
from
9ba6ca0 to
ff95cac
Compare
PhMemmel
reviewed
Feb 19, 2024
PhMemmel
reviewed
Feb 21, 2024
PhMemmel
reviewed
Feb 21, 2024
| 'callback' => '\mod_learningmap\autoupdate::reset_backlink_cache', | ||
| 'callback' => '\mod_learningmap\autoupdate::reset_backlink_cache_if_necessary', | ||
| ], | ||
| [ |
There was a problem hiding this comment.
Please add a comment that this is needed in case the course format changed. Maybe it would also be nice to make a separate callback function handling this event because it should be possible to extract if the event actually was caused by a course format change?
Currently the cache is rebuilt on every course update, right?
PhMemmel
reviewed
Feb 21, 2024
backlink config was not present in backup routine, fixed
Yes :) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.