feat(survey): webdx editing survey #12132
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Bundle StatsHey there, this message comes from a github action that helps you and reviewers to understand how these changes affect the size of this project's bundle. As this PR is updated, I'll keep you updated on how the bundle size is impacted. Total
View detailed bundle breakdownAdded No assets were added Removed No assets were removed Bigger No assets were bigger Smaller No assets were smaller Unchanged
|
caugner
approved these changes
Nov 15, 2024
There was a problem hiding this comment.
I approved, although I do not recommend merging as is.
- The survey is missing this JavaScript snippet:
yari/client/src/ui/molecules/document-survey/surveys.ts
Lines 59 to 61 in 1e86e60
- The teaser and survey question could use a bit of improvement.
- The survey potentially overlaps with the German feedback survey.
| key: SurveyKey.WEBDX_EDITING_2024, | ||
| bucket: SurveyBucket.WEBDX_EDITING_2024, | ||
| show: (doc: Pick<Doc, "mdn_url">) => | ||
| /^\/[^/]+\/docs\/Web\/API($|\/.*$)/i.test(doc.mdn_url), |
There was a problem hiding this comment.
Please exclude /de/ from this, to avoid two surveys from showing up simultaneously (unless we already prevent this, and show only the first matching one?).
There was a problem hiding this comment.
That's what it does, taking the first one only.
Comment on lines
+112
to
+113
| "Let us know your thoughts about the following text editing, formatting, selection, and clipboard APIs", | ||
| question: "Please share your feedback about the following features.", |
There was a problem hiding this comment.
Reads weird to refer to "the following", when this is only shown on demand.
Suggested change
| "Let us know your thoughts about the following text editing, formatting, selection, and clipboard APIs", | |
| question: "Please share your feedback about the following features.", | |
| "Let us know your thoughts about text editing, formatting, selection, and clipboard APIs:", | |
| question: "Please share your feedback about these features.", |
Also: @Rumyra Previous survey entry questions seemed a bit more catchy (e.g. this one, this one, and that one), and here it could be:
Browser vendors are working together to improve text editing, formatting, selection, and clipboard APIs:
Which of these features have you heard of or used?
PS: In theory, we could A/B tests this with two buckets, and see which copy gets more responses.
There was a problem hiding this comment.
Yeh I'm ok with this.
For A/B testing I'm interested in the number of respondents compared to other surveys considering it's quite long - I've already shared this feedback and we will see once it's run
There was a problem hiding this comment.
Sorry, I'm not sure whether the I'm ok with this refers to the current or updated copy. I'll land it like this and we can update it later.
Rumyra
approved these changes
Nov 15, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
WebDX Editing survey 2024
(MP-1628)
Screenshots
After
How did you test this change?
Locally deploying to test.
https://test.developer.allizom.org/en-US/docs/Web/API#FORCE_SURVEY=WEBDX_EDITING_2024