Rewrite PerformanceNavigationTiming pages #22683
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
wbamberg
reviewed
Dec 3, 2022
There was a problem hiding this comment.
I hope this is helpful!
There are a few repeated patterns here that we might look at:
- circuitous language like "a timestamp representing the time value equal to the time immediately after..." where I think "a timestamp representing the time immediately after.."
- some language about "events completing" which could be "event handlers completing" (AFAICT)
- using performance observers instead of
getEntriesByType, but noting that we should passbufferedas an option - again circuitous language like "the user agent sets the current document readiness of the current document to interactive." where something like "the user agent sets the document's
readyStateto"interactive"" seems clearer and more concise.
files/en-us/web/api/performancenavigationtiming/redirectcount/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/performancenavigationtiming/redirectcount/index.md
Outdated
Show resolved
Hide resolved
files/en-us/web/api/performancenavigationtiming/redirectcount/index.md
Outdated
Show resolved
Hide resolved
wbamberg
approved these changes
Dec 5, 2022
hamishwillee
pushed a commit
to hamishwillee/content
that referenced
this pull request
Dec 12, 2022
* Rewrite PerformanceNavigationTiming pages * Apply suggestions from code review Co-authored-by: wbamberg <[email protected]> * Update descriptions & use event handler throughout * Add PerformanceObserver examples Co-authored-by: wbamberg <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR rewrites the Navigation Timing pages to mainly provide more useful code examples. Much like for Resource Timing I'm also adding the spec's diagram here, as I think it is useful to see where the individual timestamps sit in the overall process.
Motivation
openwebdocs/project#62
Additional details
I wasn't quite sure what to demo for the
domInteractiveanddomCompleteproperties, so these examples just log out the value (lame).I think you could show the following things, but I wasn't sure if they are good ideas.
Measuring DOM construction time:
domInteractive - responseEndMeasuring DOM resources processing time:
domComplete - domInteractiveChecking if there is parser-blocking JavaScript?
domContentLoadedEventStart !== dominteractiveRelated issues and pull requests
None.