Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Chrome Android 130 also supports text-wrap-style: pretty #25394

Merged
merged 1 commit into from
Dec 12, 2024

Conversation

skyclouds2001
Copy link
Contributor

@skyclouds2001 skyclouds2001 commented Dec 12, 2024

Summary

there is no reason that the value only supported on chromium-desktop

it matches the behavior of the same value on the text-wrap property, which implemented in M117

it also matches other values of the text-wrap-style property in the same version. which all implemented in the same version

"pretty": {
"__compat": {
"mdn_url": "https://developer.mozilla.org/docs/Web/CSS/text-wrap#pretty",
"spec_url": "https://drafts.csswg.org/css-text-4/#valdef-text-wrap-style-pretty",
"tags": [
"web-features:text-wrap-pretty"
],
"support": {
"chrome": {
"version_added": "117"
},
"chrome_android": "mirror",
"edge": "mirror",
"firefox": {
"version_added": false
},
"firefox_android": "mirror",
"ie": {
"version_added": false
},
"oculus": "mirror",
"opera": "mirror",
"opera_android": "mirror",
"safari": {
"version_added": false
},
"safari_ios": "mirror",
"samsunginternet_android": "mirror",
"webview_android": "mirror",
"webview_ios": "mirror"
},
"status": {
"experimental": false,
"standard_track": true,
"deprecated": false
}
}
},

Test results and supporting details

test in local mobile device and confirms its support

#24663 - the PR that add the data

https://chromestatus.com/feature/5793719555719168 - related chromium entry

https://issues.chromium.org/issues/338529223 - related chromium bug

chromium/chromium@ee5d3f2 - related commit

Related issues

Fixes #25218

@github-actions github-actions bot added data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS size:xs [PR only] 0-6 LoC changed labels Dec 12, 2024
@skyclouds2001 skyclouds2001 marked this pull request as ready for review December 12, 2024 15:00
@caugner
Copy link
Contributor

caugner commented Dec 12, 2024

https://chromestatus.com/feature/5793719555719168 - related chromium entry

This seems to be a different feature that landed in Chrome 130.

@skyclouds2001
Copy link
Contributor Author

https://chromestatus.com/feature/5793719555719168 - related chromium entry

This seems to be a different feature that landed in Chrome 130.

this is what said in #24663 (review)

and per the commit message:

[text-wrap] Update the syntax of text-wrap to match the new spec
This patch updates the CSS syntax of the text-wrap property
and its related properties to match the new spec.

Changes are:

  1. Add a new longhand property:
    text-wrap-mode: wrap | nowrap
  2. Add a new longhand property:
    text-wrap-style: auto | balance | pretty | stable
  3. Change the text-wrap longhand property to a shorthand for
    the two properties above.
  4. Change the white-space shorthand property from:
    [white-space-collapse, text-wrap]
    to:
    [white-space-collapse, text-wrap-mode]

The change isn't under a runtime flag because making it under
a runtime flag isn't trivial due to changes in shorthand
properties and property storages, and the new behaviors are
already shipping in other engines.

@caugner
Copy link
Contributor

caugner commented Dec 12, 2024

Apologies, I got confused by the code snippet in the PR description, just had a quick look earlier. Taking another look now...

@caugner caugner changed the title css.properties.text-wrap-style.pretty supported on other chromium-based browsers Chrome Android 130 also supports text-wrap-style: pretty Dec 12, 2024
@caugner caugner merged commit f635137 into mdn:main Dec 12, 2024
8 checks passed
@skyclouds2001 skyclouds2001 deleted the text-wrap-style.pretty branch December 12, 2024 18:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
data:css Compat data for CSS features. https://developer.mozilla.org/docs/Web/CSS size:xs [PR only] 0-6 LoC changed
Projects
None yet
Development

Successfully merging this pull request may close these issues.

css.properties.text-wrap-style.pretty - support on other chromium-based browsers
2 participants