Add data points for compileOptions, which enable wasm JS string builtins #25391
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
github-actions
bot
added
data:wasm
caugner
requested changes
Dec 13, 2024
There was a problem hiding this comment.
LGTM overall, just the spec_url doesn't seem specific enough.
PS: It is what we currently do, but I really don't like this data duplication (6 feature for what is likely covered by the same implementation) and would prefer a way to inherit support data from another feature.
Elchi3
reviewed
Dec 13, 2024
Co-authored-by: Claas Augner <[email protected]>
Co-authored-by: Claas Augner <[email protected]>
Co-authored-by: Claas Augner <[email protected]>
Co-authored-by: Claas Augner <[email protected]>
Co-authored-by: Claas Augner <[email protected]>
Co-authored-by: Florian Scholz <[email protected]>
Co-authored-by: Florian Scholz <[email protected]>
Co-authored-by: Florian Scholz <[email protected]>
Co-authored-by: Florian Scholz <[email protected]>
Co-authored-by: Florian Scholz <[email protected]>
Co-authored-by: Florian Scholz <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Chrome 130 supports WebAssembly JS String builtins. Specifically, This PR adds data points for the
compileOptionsparameter used to enable these built-ins, which is added to:WebAssembly.compile()WebAssembly.compileStreaming()WebAssembly.instantiate()WebAssembly.instantiateStreaming()WebAssembly.validate()WebAssembly.Module()constructorTest results and supporting details
See https://chromestatus.com/feature/6695587390423040 for the data source. I have also tested each of the above cases and found them to work by default in Chrome 130/131.
Related issues