[eslint config] [base] [breaking] enable import/no-cycle: warn on c…

…yclical dependencies
mdmasumbillah · Apr 4, 2018 · c71e8c9 · c71e8c9
1 parent 31d95fd
commit c71e8c9
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/packages/eslint-config-airbnb-base/rules/imports.js b/packages/eslint-config-airbnb-base/rules/imports.js
@@ -228,8 +228,7 @@ module.exports = {
 
     // Forbid cyclical dependencies between modules
     // https://github.com/benmosher/eslint-plugin-import/blob/d81f48a2506182738409805f5272eff4d77c9348/docs/rules/no-cycle.md
-    // TODO: enable, semver-major
-    'import/no-cycle': ['off', { maxDepth: Infinity }],
+    'import/no-cycle': ['error', { maxDepth: Infinity }],
 
     // Ensures that there are no useless path segments
     // https://github.com/benmosher/eslint-plugin-import/issues/1032