Change import/no-self-import from "off" to "error"

We recently had an incident where this rule would have prevented infinite loops in Hypernova and in the browser.
mdmasumbillah · Mar 23, 2018 · 49dab88 · 49dab88
1 parent 8247e33
commit 49dab88
Showing 1 changed file with 1 addition and 2 deletions.
diff --git a/packages/eslint-config-airbnb-base/rules/imports.js b/packages/eslint-config-airbnb-base/rules/imports.js
@@ -224,8 +224,7 @@ module.exports = {
 
     // Forbid a module from importing itself
     // https://github.com/benmosher/eslint-plugin-import/blob/44a038c06487964394b1e15b64f3bd34e5d40cde/docs/rules/no-self-import.md
-    // TODO: enable
-    'import/no-self-import': 'off',
+    'import/no-self-import': 'error',
 
     // Ensures that there are no useless path segments
     // https://github.com/benmosher/eslint-plugin-import/issues/1032