do not block accepting connections #81
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please consider this PR, it will be appreciated by anyone looking to use the TLS functionality. |
When using a plain TCP listener, goScanConnection creates some data structures and moves on to scan which is wrapped in a goroutine. When using a TLS listener, goScanConnection does not return until the TLS handshake is complete. A lot can go wrong during this stage. This change wraps goScanConnection in a goroutine to avoid blocking accepting the next connection.
munkyboy
force-pushed
the
non-block-handshake
branch
from
495ac46 to
2ee09f4
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using a plain TCP listener, goScanConnection creates some data
structures and moves on to scan which is wrapped in a goroutine.
When using a TLS listener, goScanConnection does not return until the
TLS handshake is complete. A lot can go wrong during this stage.
This change wraps goScanConnection in a goroutine to avoid blocking
accepting the next connection.