Preserve %EF%B8%8F in GitHub anchors

Fixes thlorenz#36
mcornella · Sep 23, 2020 · ee7536f · ee7536f
1 parent 87e4cca
commit ee7536f
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 3 deletions.
diff --git a/.gitignore b/.gitignore
@@ -14,3 +14,4 @@ results
 node_modules
 npm-debug.log
 tmp
+package-lock.json
diff --git a/anchor-markdown-header.js b/anchor-markdown-header.js
@@ -38,7 +38,7 @@ function getGithubId(text, repetition) {
   }
 
   // Strip emojis
-  text = text.replace(emojiRegex(), '')
+  text = text.replace(emojiRegex(), '');
 
   return text;
 }
@@ -123,7 +123,7 @@ module.exports = function anchorMarkdownHeader(header, mode, repetition, moduleN
         // encodeURI replaces the zero width joiner character
         // (used to generate emoji sequences, e.g.Female Construction Worker 👷🏼‍♀️)
         // github doesn't URL encode them, so we replace them after url encoding to preserve the zwj character.
-        return newURI.replace(/%E2%80%8D/g, '\u200D');
+        return newURI.replace(/%E2%80%8D/g, '%EF%B8%8F');
       };
       break;
     case 'bitbucket.org':

diff --git a/test/anchor-markdown-header.js b/test/anchor-markdown-header.js
@@ -46,7 +46,9 @@ test('\ngenerating anchor in github mode', function (t) {
   , [ 'Modules 📦', null, '#modules-']
   , [ 'Modu📦les', null, '#modules']
   , [ 'Mo📦du📦les', null, '#modules']
-  , [ '👷🏼‍♀️ Maintenance', null, '#\u200D-maintenance']
+  , [ '👷🏼‍♀️ Maintenance', null, '#%EF%B8%8F-maintenance']
+  , [ 'Alarm clock ⏰', null, '#alarm-clock-']
+  , [ 'Apple Watch ⌚️', null, '#apple-watch-%EF%B8%8F']
   ].forEach(function (x) { check(x[0], x[1], x[2]) });
   t.end();
 })