Turn on persistance in examples/lints (#164)

mcnuttandrew · Oct 21, 2024 · 60df5ff · 60df5ff
1 parent 617099b
commit 60df5ff
Show file tree

Hide file tree

Showing 4 changed files with 43 additions and 26 deletions.
diff --git a/apps/color-buddy/src/example/NewExampleModal.svelte b/apps/color-buddy/src/example/NewExampleModal.svelte
@@ -36,12 +36,16 @@
 
   $: {
     if (typeof externalModalState === "number") {
-      const example = $exampleStore.examples[externalModalState] as any;
-      if (example.svg) {
+      let example = $exampleStore.examples[externalModalState] as any;
+      if (!example) {
+        example = $exampleStore.examples[0];
+      }
+      console.log(example);
+      if (example && example.svg) {
         value = example.svg;
         modalState = "input-svg";
       }
-      if (example.vega) {
+      if (example && example.vega) {
         value = example.vega;
         modalState = "input-vega";
       }
@@ -270,7 +274,15 @@
         <button
           class={buttonStyle}
           on:click={() => {
-            const example = { vega: value, name: "Custom Example", size: 300 };
+            let example = { vega: value, name: "Custom Example", size: 300 };
+            if (typeof externalModalState === "number") {
+              example = {
+                ...example,
+                ...$exampleStore.examples[externalModalState],
+                vega: value,
+              };
+            }
+            console.log(example);
             if (typeof externalModalState === "number") {
               exampleStore.updateExample(example, externalModalState);
             } else {

diff --git a/apps/color-buddy/src/example/PreviewSelector.svelte b/apps/color-buddy/src/example/PreviewSelector.svelte
@@ -5,8 +5,7 @@
   import configStore from "../stores/config-store";
   import Tooltip from "../components/Tooltip.svelte";
   export let exampleName: string;
-  $: SVGs = $exampleStore.examples.filter((x) => (x as any).svg);
-  $: vis = $exampleStore.examples.filter((x) => (x as any).vega);
+  $: examples = $exampleStore.examples as any[];
 </script>
 
 <Tooltip targetBody={false} bg="bg-white" top={0} positionAlongRightEdge={true}>
@@ -21,24 +20,27 @@
       Discs
     </button>
     <div class="w-full border border-stone-300 my-2" />
-    {#each SVGs as example, idx}
-      <button
-        class={simpleTooltipRowStyle}
-        on:click={() => configStore.setManageBrowsePreviewIdx(idx)}
-      >
-        {example.name}
-      </button>
+    {#each examples as example, idx}
+      {#if example.svg}
+        <button
+          class={simpleTooltipRowStyle}
+          on:click={() => configStore.setManageBrowsePreviewIdx(idx)}
+        >
+          {example.name}
+        </button>
+      {/if}
     {/each}
     <div class="w-full border border-stone-300 my-2" />
-    {#each vis as example, idx}
-      <button
-        class={simpleTooltipRowStyle}
-        on:click={() => configStore.setManageBrowsePreviewIdx(idx)}
-      >
-        {example.name}
-      </button>
+    {#each examples as example, idx}
+      {#if example.vega}
+        <button
+          class={simpleTooltipRowStyle}
+          on:click={() => configStore.setManageBrowsePreviewIdx(idx)}
+        >
+          {example.name}
+        </button>
+      {/if}
     {/each}
-    <div class="w-full border border-stone-300 my-2" />
   </div>
   <button
     slot="target"

diff --git a/apps/color-buddy/src/stores/example-store.ts b/apps/color-buddy/src/stores/example-store.ts
@@ -129,8 +129,11 @@ function createStore() {
       return acc;
     }, {} as any);
     if (x) {
-      const examples = x.examples.filter((x: any) => !preBuiltMap[x.name]);
-      const newStore = { examples: [...prebuiltExamples, ...examples] };
+      // if there are prebuilt examples, add them to the store
+      x.examples.forEach((x: any) => {
+        preBuiltMap[x.name] = x;
+      });
+      const newStore = { examples: Object.values(preBuiltMap) };
       set(newStore as StoreData);
     } else {
       set({ ...InitialStore, examples: prebuiltExamples });

diff --git a/apps/color-buddy/src/stores/lint-store.ts b/apps/color-buddy/src/stores/lint-store.ts
@@ -103,9 +103,9 @@ function createStore() {
     let lints = (storeBase.lints || []) as LintProgram[];
     // force-ably set lints to defaults
     // TODO turn off for release...
-    lints = lints.map(
-      (x: LintProgram) => builtInIndex[x.id] || x
-    ) as LintProgram[];
+    // lints = lints.map(
+    //   (x: LintProgram) => builtInIndex[x.id] || x
+    // ) as LintProgram[];
     const missingBuiltIns = PREBUILT_LINTS.filter(
       (x) => !lints.find((y) => y.id === x.id)
     ).map((x) => ({