Add fallback modifier #158
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Thanks for the PR! Will check out when I have a free moment, just got back from a trip. |
|
Don't worry! I'm also quite occupied with exams and vacations so I might be quite slow to answer. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #24
I have yet to test this deeply (I intend to build a PoC Noise Channel), this is tested with XXfallback and it seems to work correctly.
This is implemented by transferring the first message pattern into Alice pre-message (if empty), then reversing the patterns to be Bob-initialized. The other implementation option would be to have something track whether the connection is Alice or Bob initialized, but this seems like the simpler way.
In my github fork I'm working on other changes (Elligator2 support and message overhead/simulation), but this seems like the simplest one to upstream as it does not add any strange API.