Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
When using
opengl-accelerate
, many operations will fail if passed anumpy.array
which is contiguous, but is not writeable, e.g.:results in:
This is because
accelerate/src/numpy_formathandler.pyx
uses thePyArray_ISCARRAY
function to test whether an array is contiguous. However,PyArray_ISCARRAY
also tests whether an array is writeable.This PR simply changes
numpy_formathandler.pyx
so it usesPyArray_ISCARRAY_RO
rather thanPyArray_ISCARRAY
, so that read-only arrays are accepted.This issue has arisen in my work due to a recent change in
numpy
which causes data loaded vianp.frombuffer
to be set as read-only.The change to
numpy_formathandler.pyx
seems to work fine for me, although I am not sure whether some circumstances do actually require arrays to be writeable. If this is the case, please disregard this PR.