Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix #1: add support to read from Catena FRAM #2

Open
wants to merge 13 commits into
base: master
Choose a base branch
from
Open

Fix #1: add support to read from Catena FRAM #2

wants to merge 13 commits into from

Conversation

dhineshkumarmcci
Copy link
Member

No description provided.

@disk91
Copy link
Collaborator

disk91 commented Feb 23, 2021

looks good from helicopter view.
Just a remark on Key Management. It would be nice to encrypt the Sigfox key if not, at least, you should have no API for the end user to read it. This is a secret you should only write ; only the internal sigfox driver needs to access it.

@dhineshkumarmcci
Copy link
Member Author

hi Paul, thanks for the review. I will make the necessary changes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@terrillmoore terrillmoore Awaiting requested review from terrillmoore

Assignees

@terrillmoore terrillmoore

@dhineshkumarmcci dhineshkumarmcci

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@dhineshkumarmcci @disk91 @terrillmoore