Improvements to mbeddr search tool #2650
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
It was a threading issue. Updating the UI not from the UI thread is not a good idea. |
HeikoBecker
requested changes
Dec 12, 2024
There was a problem hiding this comment.
Functional Review:
- I cannot use the search functionality on solutions:
- Searching modules for some elements returns weird results:
- Levensthein based search for words of size 2 is a bit nonsensical in my opinion:
- Can we make the search window active with global/project scope per default? Maybe via an extension point? If I do not know about the existence of the search option in the logical view, this would make it easier to find.
Updating the UI takes took long for more results and it freezes.
The search results are correct, the string "test" appears in all of them and you are ignoring the case. |
alexanderpann
force-pushed
the
bugfix/improve_search_tool
branch
from
ed47e6c to
d948b7d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The mbeddr search tool was improved: It can now also search the project and globally. It also got options for approximate searching with an error distance, and matching the case. The UI was also improved: