Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DSL for MPS jars #29

Merged
merged 2 commits into from
Nov 4, 2024
Merged

DSL for MPS jars #29

merged 2 commits into from
Nov 4, 2024

Conversation

sergej-koscejev
Copy link
Member

Introduce a simple inline DSL for describing MPS jars to publish

@sergej-koscejev
Copy link
Member Author

Alternatively, maybe we should get rid of these jars altogether? It may make life more difficult for Maven users but we will never publish all possible jars so it seems like we're solving a problem we can't solve.

Anyway, my primary motivation for this PR was to change the build to use mpsVersion lazily, so that it could be imported into IDEA even if no explicit version is defined, but I then realized that we have conditional publications (mps-messaging is published only for MPS version below 2022.3) and this is not straightforward to implement. So I haven't reached the goal yet, but I think that the DSL is nevertheless worth introducing.

Copy link
Member

@alexanderpann alexanderpann left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think it is still useful to publish the most common JARs and the DSL looks quite useful. I also run into the case in the past, that some JARs that I needed were not published. Can we maybe provide some instructions for at least Gradle users how they can get the remaining JARs themselves?

@sergej-koscejev
Copy link
Member Author

Can we maybe provide some instructions for at least Gradle users how they can get the remaining JARs themselves?

These instructions are already part of README.md.

@alexanderpann
Copy link
Member

Oh, I didn't check the README. Thanks.

@sergej-koscejev sergej-koscejev merged commit e3f0444 into master Nov 4, 2024
1 check passed
@sergej-koscejev sergej-koscejev deleted the feature/dsl-for-jars branch November 4, 2024 13:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants