fix: ESlint configuration for typescript

mbarzeev · Mar 5, 2024 · 9af8700 · 9af8700
1 parent db51bde
commit 9af8700
Show file tree

Hide file tree

Showing 12 changed files with 453 additions and 152 deletions.
diff --git a/.eslintrc.json b/.eslintrc.json
@@ -1,5 +1,6 @@
 {
     "root": true,
+    "parser": "@typescript-eslint/parser",
     "env": {
         "browser": true,
         "commonjs": true
@@ -14,14 +15,24 @@
         "ecmaVersion": 2020,
         "sourceType": "module"
     },
+    "overrides": [
+        {
+            "files": ["*.js", "*.jsx", "*.ts", "*.tsx"]
+        }
+    ],
     "globals": {
         "describe": true,
         "it": true,
         "expect": true,
-        "jest": true
+        "jest": true,
+        "beforeAll": true,
+        "beforeEach": true,
+        "process": true
     },
-    "plugins": ["@pedalboard/craftsmanlint"],
+    "plugins": ["@typescript-eslint", "@pedalboard/craftsmanlint"],
     "rules": {
-        "@pedalboard/craftsmanlint/no-namespace-imports": ["error"]
+        "@pedalboard/craftsmanlint/no-namespace-imports": ["error"],
+        "no-unused-vars": "off",
+        "@typescript-eslint/no-unused-vars": "error"
     }
 }
diff --git a/package.json b/package.json
@@ -35,6 +35,8 @@
         "@pedalboard/scripts": "^0.2.0",
         "@swc/core": "^1.3.24",
         "@swc/jest": "^0.2.24",
+        "@typescript-eslint/eslint-plugin": "^7.1.1",
+        "@typescript-eslint/parser": "^7.1.1",
         "lerna": "^5.0.0",
         "nyc": "^15.1.0"
     },

diff --git a/packages/components/jest.config.js b/packages/components/jest.config.js
@@ -5,4 +5,6 @@ module.exports = {
     moduleNameMapper: {
         '\\.(css|less|scss|sass)$': 'identity-obj-proxy',
     },
+    collectCoverageFrom: ['src/**/*.{js,jsx,ts,tsx}', '!', '!**/node_modules/**'],
+    coveragePathIgnorePatterns: ['.cy.js', '.stories.tsx'],
 };
diff --git a/packages/components/package.json b/packages/components/package.json
@@ -51,13 +51,14 @@
         "@storybook/test": "^7.6.12",
         "@testing-library/jest-dom": "^5.16.2",
         "@testing-library/react": "^12.1.3",
+        "@types/react": "^18.2.61",
         "babel-jest": "^27.5.1",
         "babel-loader": "^8.2.3",
         "chromatic": "10.6.1",
         "cypress": "^10.1.0",
         "esbuild": "^0.15.7",
         "esbuild-sass-plugin": "^2.4.5",
-        "eslint": "^8.4.1",
+        "eslint": "8.57.0",
         "eslint-plugin-react": "^7.28.0",
         "eslint-plugin-storybook": "^0.6.15",
         "identity-obj-proxy": "^3.0.0",

diff --git a/packages/eslint-plugin-craftsmanlint/package.json b/packages/eslint-plugin-craftsmanlint/package.json
@@ -26,7 +26,7 @@
     "devDependencies": {
         "@babel/core": "^7.16.5",
         "@babel/preset-env": "^7.16.11",
-        "eslint": "^8.4.1",
+        "eslint": "8.57.0",
         "jest": "^27.4.3",
         "typescript": "^4.6.4"
     }

diff --git a/packages/git-hooks/package.json b/packages/git-hooks/package.json
@@ -31,7 +31,7 @@
         "@babel/core": "^7.16.5",
         "@babel/preset-env": "^7.16.11",
         "babel-jest": "^27.4.5",
-        "eslint": "^8.4.1",
+        "eslint": "8.57.0",
         "jest": "^27.4.3",
         "typescript": "^4.6.4"
     },

diff --git a/packages/git-hooks/src/conventional-commits-validation-hook/index.ts b/packages/git-hooks/src/conventional-commits-validation-hook/index.ts
@@ -5,6 +5,7 @@
  * LICENSE file in the root directory of this source tree.
  */
 
+/* eslint-disable no-useless-escape */
 import fs from 'fs';
 import GitHook from '../GitHook';
 

diff --git a/packages/hooks/package.json b/packages/hooks/package.json
@@ -37,8 +37,8 @@
         "@babel/preset-env": "^7.16.11",
         "@testing-library/react-hooks": "^7.0.2",
         "babel-jest": "^27.4.5",
-        "eslint": "^8.4.1",
+        "eslint": "8.57.0",
         "jest": "^27.4.3",
-        "typescript": "^4.6.4"
+        "typescript": "^5.3.3"
     }
 }
diff --git a/packages/scripts/package.json b/packages/scripts/package.json
@@ -21,7 +21,7 @@
         "lint": "eslint ./src"
     },
     "devDependencies": {
-        "eslint": "^8.4.1",
+        "eslint": "8.57.0",
         "jest": "^27.4.3"
     },
     "dependencies": {

diff --git a/packages/stylelint-plugin-craftsmanlint/package.json b/packages/stylelint-plugin-craftsmanlint/package.json
@@ -36,6 +36,7 @@
         "@babel/core": "^7.16.5",
         "@babel/preset-env": "^7.16.11",
         "csstype": "^3.1.1",
+        "eslint": "8.57.0",
         "jest": "^27.4.3",
         "jest-preset-stylelint": "7.0.0",
         "ts-node": "^10.9.1",

diff --git a/packages/stylelint-plugin-craftsmanlint/src/rules/props-in-files/index.ts b/packages/stylelint-plugin-craftsmanlint/src/rules/props-in-files/index.ts
@@ -5,7 +5,8 @@
  * LICENSE file in the root directory of this source tree.
  */
 
-import stylelint, {RuleMessage} from 'stylelint';
+/* eslint-disable @pedalboard/craftsmanlint/no-namespace-imports */
+import stylelint from 'stylelint';
 import * as CSS from 'csstype';
 import type * as PostCSS from 'postcss';
 
@@ -16,7 +17,6 @@ type Policy = {
 };
 
 type PrimaryOption = Record<keyof CSS.StandardPropertiesHyphen, Partial<Policy>>;
-type SecondaryOption = Record<'severity', 'error' | 'warning'>;
 
 const ruleName = 'stylelint-plugin-craftsmanlint/props-in-files';
 const messages = stylelint.utils.ruleMessages(ruleName, {
@@ -31,7 +31,7 @@ const meta = {
 
 const ALL_FILES_KEYWORD = 'all';
 
-const ruleFunction = (primaryOption: PrimaryOption, secondaryOptionObject: SecondaryOption) => {
+const ruleFunction = (primaryOption: PrimaryOption) => {
     return (postcssRoot: PostCSS.Root, postcssResult: stylelint.PostcssResult) => {
         const validOptions = stylelint.utils.validateOptions(postcssResult, ruleName, {
             actual: null,