Completed requirements specification (PyQt4 and requests) and improved setup.py #5
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changelist:
setup.py
to work without havingPyQt4
installed (so you can install it later):hashmal_lib.entry_points
module to contain entry pointshashmal_lib.gui_utils
module's constanthashmal_entry_points
to previously created fileContains a reference to it to mantain constant in both modules
setup.py
importfrom hashmal_lib.gui_utils import hashmal_entry_points
tofrom hashmal_lib.entry_points import hashmal_entry_points
hashmal_lib.__init__
module imports to inside the class (so doesn't importPyQt4
until instanced)requests
module as a requirement inrequirements.txt
README.md
thePyQt4
requirement and a basic how-to to install the modulebuild/
anddist/
to.gitignore