Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Completed requirements specification (PyQt4 and requests) and improved setup.py #5

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

davidlj95
Copy link

Changelist:

  • Fixed setup.py to work without having PyQt4 installed (so you can install it later):
    • Created hashmal_lib.entry_points module to contain entry points
    • Moved hashmal_lib.gui_utils module's constant hashmal_entry_points to previously created file
      Contains a reference to it to mantain constant in both modules
    • Changed setup.py import from hashmal_lib.gui_utils import hashmal_entry_points to from hashmal_lib.entry_points import hashmal_entry_points
    • Moved hashmal_lib.__init__ module imports to inside the class (so doesn't import PyQt4 until instanced)
  • Added requests module as a requirement in requirements.txt
  • Explained in README.md the PyQt4 requirement and a basic how-to to install the module
  • Added build/ and dist/ to .gitignore

Added extra documentation explaining PyQt must be installed
Moved some files to avoid setup fail without PyQt4 installed
Xiaoyang-Zhu added a commit to Xiaoyang-Zhu/hashmal that referenced this pull request Sep 16, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant