Add test-case for Fix parameter output if parameter is Datetime or array [v1.22.4] #671

demo/bridge/doctrine/index.php

@@ -11,9 +11,10 @@
 
 $product = new Demo\Product();
 $product->setName("foobar");
-
+$product->setUpdated();
 
 $entityManager->persist($product);
 $entityManager->flush();
+$entityManager->createQuery("select p from  Demo\\Product p where p.updated>:u")->setParameter("u", new \DateTime('1 hour ago'))->execute();
 $entityManager->createQuery("select p from  Demo\\Product p where p.name=:c")->setParameter("c", "<script>alert();</script>")->execute();
 render_demo_page();

demo/bridge/doctrine/src/Demo/Product.php

@@ -11,6 +11,8 @@ class Product
     protected $id;
     /** @Column(type="string") **/
     protected $name;
+    /** @Column(type="datetime", nullable=true) **/
+    protected $updated;
 
     public function getId()
     {
@@ -26,4 +28,10 @@ public function setName($name)
     {
         $this->name = $name;
     }
+
+    public function setUpdated(): void
+    {
+        // will NOT be saved in the database
+        $this->updated = new \DateTime('now');
+    }
 }

src/DebugBar/Bridge/DoctrineCollector.php

@@ -82,11 +82,16 @@ public function collect()
      */
     public function getParameters($query) : array
     {
-        $params = [];
-        foreach ($query['params'] ?? [] as $name => $param) {
-            $params[$name] = htmlentities($param?:"", ENT_QUOTES, 'UTF-8', false);
-        }
-        return $params;
+        return array_map(function ($param) {
+            if (is_string($param)) {
+                return htmlentities($param, ENT_QUOTES, 'UTF-8', false);
+            } elseif (is_array($param)) {
+                return implode(', ', $param);
+            } elseif ($param instanceof \DateTimeInterface) {
+                return $param->format('Y-m-d H:i:s');
+            }
+            return $param ?: '';
+        }, $query['params'] ?? []);
     }
 
     /**

tests/DebugBar/Tests/Browser/Bridge/DoctrineTest.php

@@ -32,8 +32,8 @@ public function testMonologCollector(): void
                 return $node->getText();
             });
 
-        $this->assertEquals('INSERT INTO products (name) VALUES (?)', $statements[1]);
-        $this->assertCount(4, $statements);
+        $this->assertEquals('INSERT INTO products (name, updated) VALUES (?, ?)', $statements[1]);
+        $this->assertCount(5, $statements);
     }
 
 }