Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Update js_wasm.go #957

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

NrdyBhu1
Copy link

Added an alert function.
This can be useful in debugging along with other stuff

Added an alert function.
This can be useful in debugging along with other stuff
@oderwat
Copy link
Contributor

oderwat commented May 28, 2024

But you can just call app.Window().Call("alert", "my alert") already?

@NrdyBhu1
Copy link
Author

I just realized that now, but even if it is small change, it makes it a little bit easy ig?

@oderwat
Copy link
Contributor

oderwat commented May 28, 2024

@maxence-charriere needs to decide that.

I think that adding things like this beg the question of why not add confirm() and prompt() and maybe other stuff too. And why is it not alert(format string, args ...any) and so on. It could make it "easier" but it also hides app.Window().Call() even more and makes the API bigger with something I will probably never use :)

@NrdyBhu1
Copy link
Author

You are right in that point, I do not know whether to close but I will respect the final decision.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants