Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support Slack's <!date> formatting #40

Merged
merged 1 commit into from
Apr 5, 2024
Merged

Support Slack's <!date> formatting #40

merged 1 commit into from
Apr 5, 2024

Conversation

twouters
Copy link
Contributor

@twouters twouters changed the title Support Slack's <!date> field Support Slack's <!date> formatting Oct 16, 2023
@twouters twouters force-pushed the feature/special-mention-date branch from a9368ab to 464811a Compare October 16, 2023 12:30
@twouters twouters force-pushed the feature/special-mention-date branch from 464811a to 1918fc8 Compare October 16, 2023 12:59
@twouters
Copy link
Contributor Author

Just a sidenote: I opted for the format January 2, 2006 instead of the documented Slack format January 2nd, 2006 because Go's time library doesn't support it natively and I didn't want to introduce another dependency (like go-humanize) just to get the suffixes right, nor implement it manually because it would lack localization.

@tulir tulir merged commit 80c21b2 into mautrix:main Apr 5, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tulir tulir tulir approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@twouters @tulir