Support message attachments legacy fields #39
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
forgot to mention that the code doesn't take the |
twouters
force-pushed
the
feature/attachments-legacy-fields
branch
from
a86bf1c to
f5d821f
Compare
twouters
commented
Oct 9, 2023
blocks.go
Outdated
| } | ||
| ts, _ := attachment.Ts.Int64() | ||
| t := time.Unix(ts, 0) | ||
| htmlText.WriteString(fmt.Sprintf("%s", t.Local().Format("Jan 02, 2006 15:04:05"))) |
There was a problem hiding this comment.
Just noticed that the docker image doesn't have the tzdata package installed, which is probably required to use the local timezone instead of UTC here.
twouters
force-pushed
the
feature/attachments-legacy-fields
branch
from
f5d821f to
ec3b339
Compare
twouters
force-pushed
the
feature/attachments-legacy-fields
branch
from
84e9fd4 to
801e70c
Compare
twouters
force-pushed
the
feature/attachments-legacy-fields
branch
from
801e70c to
0f5eedc
Compare
tulir
approved these changes
Mar 29, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
As documented at https://api.slack.com/reference/messaging/attachments
Some bots that are used at my employer use the legacy attachments formatting instead of blocks so I hacked this in.
This should probably be a separate function and could be refactored to reduce some nesting, but this is what I'm running right now.
The current version is missing support for the following items because I haven't got around to handle images inside messages but it shouldn't be too hard to implement by refactoring
renderImageBlocka bit:Not sure if this warrants a draft to wait until images are handled or if this can be added as is (after review).