Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Create a real UMD script #12

Closed
wants to merge 2 commits into from
Closed

Create a real UMD script #12

wants to merge 2 commits into from

Conversation

ZsharE
Copy link
Contributor

@ZsharE ZsharE commented Apr 20, 2024

  • Browserify package was installed
  • a real UMD script was created

@mattickx
Copy link
Owner

As this is basically just a dependency change, could you explain to me the benefit of this compared to the currently implemented UMD package?

@ZsharE
Copy link
Contributor Author

ZsharE commented Apr 22, 2024

The current UMD package cannot be loaded in the browser.

There is an open issue in the original repository that addresses this issue here:
se-panfilov/jsvat#105

I also changed the build:umd script in the package.json file.

@mattickx
Copy link
Owner

The current UMD package cannot be loaded in the browser.

There is an open issue in the original repository that addresses this issue here: se-panfilov#105

I also changed the build:umd script in the package.json file.

Thanks for clarifying.
Could you provide a simple index.html with a simple example in, such that this can be tested for this PR and in the future aswell please ?

@ZsharE
Copy link
Contributor Author

ZsharE commented Apr 23, 2024

Test page added.

@mattickx mattickx mentioned this pull request Apr 24, 2024
@mattickx mattickx closed this in faaf4eb Apr 24, 2024
@mattickx
Copy link
Owner

mattickx commented Apr 24, 2024

I've added your changes but your yarn.lock file still had remainders of your attempt from PR #11

For some reason my editor created a new PR (PR #13).
I've used PR #13 to merge this in, and gave you credit there.
I've also linked back to this PR.

Thank you for your contribution! 🚀

@mattickx
Copy link
Owner

@ZsharE Forgot to publish a new version on npm, which I have done so just now

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants