Use HTTPS for Vimeo OAuth and endpoint requests. #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Rebased a commit into this PR so that all specs now pass. |
|
+1 |
|
+1 |
|
Thanks for merging this. |
|
Are you planning to cut a new release anytime soon? |
|
Any new release in sight? |
|
here is your friendly bi-monthly release reminder ;) |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Using HTTPS ensures, among other advantages, that URLs to assets returned by (e.g.) the videos endpoint will point to the version of the resource served over HTTPS, so that we get
https://secure-b.vimeocdn...instead ofhttp://b.vimeocdn....I was unable to check whether this breaks any specs, as I couldn't get the test suite to run -- #33.