-
Notifications
You must be signed in to change notification settings - Fork 2
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
docs: add Google Play badge to README.md and remove contributors #86
base: main
Are you sure you want to change the base?
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I would decline this PR. But we can of course talk about it if you want.
README.md
Outdated
@@ -11,25 +11,32 @@ Your personal practice companion | |||
</p> | |||
|
|||
<br/> | |||
|
|||
<p align="center"> | |||
<a href='https://play.google.com/store/apps/details?id=app.musikus&hl=de&pcampaignid=pcampaignidMKT-Other-global-all-co-prtnr-py-PartBadge-Mar2515-1'> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I don't think, we should use the GooglePlay Badge while the link only works for our alpha testers.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Do you think it confuses people who don't read the description and wonder why the link is not working 😅?
Adding a Google Play badge is kind of an eyecatcher to see that we are already testing the app on Google Play.
README.md
Outdated
If you want to join our group of testers, write us an email to [[email protected]](mailto:[email protected]) using your Gmail-account and we will add you to the list. | ||
|
||
If you want to join our group of testers, write us an email to [[email protected]](mailto:[email protected]) using your Google account and we will add you to the list. If you are amongst the list of testers, the badge above will bring you to the Play Store listing. | ||
Alternatively, you can always download the latest release [from GitHub](https://github.com/matthiasemde/musikus-android/releases/latest). |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
People can download the latest release from GitHub, but then they are not really joining the alpha. The alpha is happening on GooglePlay.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Okay, fair point. But I would like to encourage people to test the app even though they might not want to be an "official alpha tester".
It's just about mentioning that our releases are also uploaded to GitHub.
Maybe we can rephrase it to something like "Pre-built release apks can be found on the release page".
README.md
Outdated
## 👨💻 Contributors | ||
<a href="https://github.com/matthiasemde/musikus-android/graphs/contributors"> | ||
<img width="140" src="https://contrib.rocks/image?repo=matthiasemde/musikus-android" alt="https://github.com/matthiasemde/musikus-android/graphs/contributors"/> | ||
</a> |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I know it's a gimmick, but I really like the contributors page.
Since the CI badge showed "failing" because of a recent CI run in an intermediate branch in a PR, I added |
My guess is, that the CI has never actually run for |
I improved our README a bit: I added a Google Play badge and removed the Contributors section for now since it is visible anyways on the sidebar of the repository in an equal fashion.
Link to a rendered version of new README