[experimental] fable support #4
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
It is just to get the ball going, and identify potential issues in the different fable targets, not expecting this would get merged and maintained in the same fashion as the .net target.
I only had to make a mock of
System.Memory, which for now will copy the array when using offsets and length that aren't corresponding to the raw input array.There is no support for FsCheck in Fable, AFAIK, so I'll consider bringing some of the documentation examples as plain tests.
Right now in the python target:
lengthargument ofMemoryconstructor to a local, otherwise Fable2Python gets confused and generateslen(x)(where x is of typeMemory).I'll give a shot at rust by end of the week.