Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[GH-982]: Added support for webhook of plugin version v2.x.x #989

Merged
merged 2 commits into from
Oct 23, 2023

Conversation

Kshitij-Katiyar
Copy link
Contributor

Summary

  • Added the endpoint to support the webhooks created for plugin version v2.x.x

Issue link

#982

What to test

-The webhook created for jira plugin version 2. x.x should be supported and working fine.

How to test

@codecov-commenter
Copy link

codecov-commenter commented Oct 18, 2023

Codecov Report

All modified lines are covered by tests ✅

Comparison is base (6109662) 29.65% compared to head (20a12fa) 29.66%.
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master     #989   +/-   ##
=======================================
  Coverage   29.65%   29.66%           
=======================================
  Files          52       52           
  Lines        7792     7798    +6     
=======================================
+ Hits         2311     2313    +2     
- Misses       5285     5289    +4     
  Partials      196      196           
Files Coverage Δ
server/http.go 70.64% <100.00%> (+0.59%) ⬆️

... and 2 files with indirect coverage changes

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Contributor

@mickmister mickmister left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM for the api/v2/webhook path, though we also need to support the /webhook path

server/http.go Show resolved Hide resolved
@mickmister mickmister added the 3: QA Review Requires review by a QA tester label Oct 19, 2023
@mickmister
Copy link
Contributor

@Kshitij-Katiyar Have you tested the following permutations for this:

  • /webhook
  • /api/v2/webhook
  • instance/INSTANCE_ID/webhook
  • instance/INSTANCE_ID/api/v2/webhook

If so I think we can merge this

@Kshitij-Katiyar
Copy link
Contributor Author

@Kshitij-Katiyar Have you tested the following permutations for this:

  • /webhook
  • /api/v2/webhook
  • instance/INSTANCE_ID/webhook
  • instance/INSTANCE_ID/api/v2/webhook

If so I think we can merge this

@mickmister I have tested for all 4 API endpoints and we are getting the notifications in the cases.

@mickmister mickmister merged commit ee2da0d into mattermost:master Oct 23, 2023
7 checks passed
@mickmister mickmister mentioned this pull request Oct 25, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: QA Review Requires review by a QA tester
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants