Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[MM-1137]: Added Autolink support for cloud-oauth #1139

Open
wants to merge 8 commits into
base: master
Choose a base branch
from
Open

[MM-1137]: Added Autolink support for cloud-oauth #1139

wants to merge 8 commits into from
+326 −40

Conversation

Kshitij-Katiyar
Copy link
Contributor

@Kshitij-Katiyar Kshitij-Katiyar commented Nov 15, 2024 •
edited
Loading

Summary

  • Added support for CloudOAuth for Autolink
  • Updated the API call to get Issues with AdminAPIToken
  • Added test cases for the SetupAutoLink function

Ticket Link

Fixes #1137

What to test

  • Autolink for Jira tickets
  • Issue comment notification after the admin has disconnected his Jira account
  • Keep an eye on the server logs

Testing step

  • Install autolink plugin for you MM
  • Install Jira plugin
  • Add the admin API token and admin email in the Jira plugin configuration before enabling it
  • enable the plugin
  • Paste a link to a jira ticket on your MM chat

@Kshitij-Katiyar Kshitij-Katiyar mentioned this pull request Nov 18, 2024
Open
@raghavaggarwal2308 raghavaggarwal2308 added 2: Dev Review Requires review by a core committer 3: QA Review Requires review by a QA tester labels Nov 22, 2024
@raghavaggarwal2308 raghavaggarwal2308 mentioned this pull request Nov 22, 2024
Open
raghavaggarwal2308
raghavaggarwal2308 requested changes Dec 4, 2024
View reviewed changes
plugin.json Outdated Show resolved Hide resolved
plugin.json Outdated Show resolved Hide resolved
plugin.json Outdated Show resolved Hide resolved
server/issue.go Outdated Show resolved Hide resolved
server/plugin.go Show resolved Hide resolved
server/plugin.go Show resolved Hide resolved
server/plugin.go Outdated Show resolved Hide resolved
server/plugin.go Outdated Show resolved Hide resolved
server/plugin.go Outdated Show resolved Hide resolved
server/plugin_test.go Outdated Show resolved Hide resolved
raghavaggarwal2308
raghavaggarwal2308 requested changes Dec 5, 2024
View reviewed changes
plugin.json Outdated Show resolved Hide resolved
plugin.json Outdated Show resolved Hide resolved
plugin.json Outdated Show resolved Hide resolved
server/plugin.go Outdated Show resolved Hide resolved
wiggin77
wiggin77 reviewed Dec 16, 2024
View reviewed changes
plugin.json Outdated Show resolved Hide resolved
wiggin77
wiggin77 reviewed Dec 16, 2024
View reviewed changes
plugin.json Outdated Show resolved Hide resolved
wiggin77
wiggin77 approved these changes Dec 16, 2024
View reviewed changes
Copy link
Member

@wiggin77 wiggin77 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Approved after two minor text edits are applied.

@raghavaggarwal2308 @wiggin77
Review fixes
fbb2462 
Co-authored-by: Doug Lauder <[email protected]>
@raghavaggarwal2308 raghavaggarwal2308 removed the 2: Dev Review Requires review by a core committer label Dec 17, 2024
@arush-vashishtha
Copy link

@Kshitij-Katiyar While testing this PR and upon enabling the Jira plugin in the plugin management, I am getting the following server logs, please look into it. Also, the auto links are not working for Jira issues.
image

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@raghavaggarwal2308 raghavaggarwal2308 raghavaggarwal2308 approved these changes

@wiggin77 wiggin77 wiggin77 approved these changes

@AayushChaudhary0001 AayushChaudhary0001 Awaiting requested review from AayushChaudhary0001

Assignees

@Kshitij-Katiyar Kshitij-Katiyar

Labels
3: QA Review Requires review by a QA tester
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Autolinks are not working in Jira after switching to oauth2
4 participants
@Kshitij-Katiyar @arush-vashishtha @wiggin77 @raghavaggarwal2308