Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Expand app quick start guides #1106

Merged
merged 37 commits into from
Oct 7, 2022
Merged

Conversation

azigler
Copy link
Contributor

@azigler azigler commented Aug 24, 2022

Fixes:

Adds:

Blocked guides:

  • Golang
    • Lifecycle - Go error when trying to install and use lifecycle bindings.
    • Oauth2 - Requires the entire dev setup to be exposed to the web via something like ngrok, will require more thought.
    • Webhooks - /hello-webhooks info endpoint does nothing when sent to, app does not report messages to channel.

@azigler azigler added Work in Progress Not yet ready for review preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories labels Aug 24, 2022
@azigler azigler self-assigned this Aug 24, 2022
@github-actions
Copy link

Preview environment failed.

1 similar comment
@github-actions
Copy link

Preview environment failed.

@github-actions
Copy link

Newest code from azigler has been published to preview environment for Git SHA 80371ba

@azigler
Copy link
Contributor Author

azigler commented Aug 24, 2022

/update-branch

@github-actions
Copy link

Newest code from mattermod has been published to preview environment for Git SHA 01ff486

@github-actions
Copy link

Newest code from azigler has been published to preview environment for Git SHA 1c60676

- tidy up language
@github-actions
Copy link

Newest code from azigler has been published to preview environment for Git SHA f18c650

- clean up language in other quick start guides
@azigler
Copy link
Contributor Author

azigler commented Aug 25, 2022

/update-branch

site/content/integrate/apps/_index.md Outdated Show resolved Hide resolved
site/content/integrate/apps/_index.md Outdated Show resolved Hide resolved
site/content/integrate/apps/_index.md Outdated Show resolved Hide resolved
site/content/integrate/apps/_index.md Outdated Show resolved Hide resolved
site/content/integrate/apps/_index.md Outdated Show resolved Hide resolved
Copy link
Contributor

@neflyte neflyte left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Found another couple things; sorry for the multiple reviews.

site/content/integrate/apps/quickstart/_index.md Outdated Show resolved Hide resolved
@github-actions
Copy link

Newest code from cwarnermm has been published to preview environment for Git SHA 1acf0cf

@github-actions
Copy link

Newest code from levb has been published to preview environment for Git SHA 18451aa

@cwarnermm
Copy link
Member

@azigler - The dev docs site has seen a lot of changes recently. Given the age of this PR, would you be open to reviewing the changes proposed in this PR against content available in production to confirm whether we want to move ahead with this PR?

@azigler
Copy link
Contributor Author

azigler commented Oct 4, 2022

@cwarnermm Thanks for checking about this one. From what I can tell, there are just tiny conflicts on two of the quickstart pages in this PR currently, and both can just be resolved in favor of this PR because it's a full revamp of those pages. Our current developer tutorials for apps are very spare, so I think getting this out soon (especially at the dawn of Hacktoberfest) is best, and then we can continue to iterate -- it's great to see we have a lot of ideas about improving these docs!

Despite the age, I don't think any of the content is expired, it seems to be working on my end. I see Alan has feedback about file permissions when running Docker, but that's a separate Docker issue outside of this guide that I can help address with him.

Let me know how you'd like to proceed!

@cwarnermm
Copy link
Member

Sounds great, @azigler! Would you be open to resolving the outstanding feedback and merge conflicts on this PR? Once resolved, we can merge this great update into production.

@azigler azigler requested a review from neflyte October 6, 2022 20:41
@azigler
Copy link
Contributor Author

azigler commented Oct 6, 2022

/update-branch

@github-actions
Copy link

github-actions bot commented Oct 6, 2022

Newest code from azigler has been published to preview environment for Git SHA 9310637

@azigler
Copy link
Contributor Author

azigler commented Oct 6, 2022

Sounds great, @azigler! Would you be open to resolving the outstanding feedback and merge conflicts on this PR? Once resolved, we can merge this great update into production.

Do you hear that? The quiet stillness? That's the sound of 214 individually resolved conversations! This PR has been an incredible effort by everyone -- @neflyte @cwarnermm @mickmister these guides wouldn't exist without y'all's sagely perspectives! 🧙

I resolved Alan's comments, incorporated the changes, and fixed the conflicts. I also merged master into this branch to update it. It failed to build at first, but then I fixed the link to @jordanafung's new contributor pages and now it's good!

I'd love to see this get merged to bolster Hacktoberfest app integrators and put resources in their hands ASAP. This is a night-and-day difference over what's currently there, and once it's live we'll continue to iterate because it's clear we all care very much about making these guides successful -- and I love it! ✨

@cwarnermm please let me know if there are any obstacles to merge at this time.

@github-actions
Copy link

github-actions bot commented Oct 7, 2022

Newest code from cwarnermm has been published to preview environment for Git SHA 0907ad5

@cwarnermm cwarnermm merged commit 133749c into master Oct 7, 2022
@cwarnermm cwarnermm deleted the azigler-restructure-app-guides branch October 7, 2022 17:05
@cwarnermm cwarnermm added 4: Reviews Complete All reviewers have approved the pull request and removed 1: Dev Review Requires review by a core commiter preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories labels Oct 7, 2022
@github-actions
Copy link

github-actions bot commented Oct 7, 2022

Newest code from cwarnermm has been published to preview environment for Git SHA 0907ad5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
4: Reviews Complete All reviewers have approved the pull request
Projects
None yet
6 participants