Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updating weblate scripts #21

Open
wants to merge 34 commits into
base: master
Choose a base branch
from
Open

Updating weblate scripts #21

wants to merge 34 commits into from

Conversation

ctlaltdieliet
Copy link
Contributor

  • Retrieving all Shipped languages (more than one page)
  • Adding reminder when component is locked for more than one week
  • Fixing typo so that people are tagged correctly
    cc @cwarnermm

Tom De Moor and others added 28 commits July 19, 2022 16:03
Adding Weblate scripts
94c70c7
added Focalboard and Playbooks
edb353b
better error-catching and locking WIP instead of deleting translations
5720c40
fixing lock on Weblate (wrong url)
d9fb362
@ctlaltdieliet
Merge branch 'master' into weblate_scripts
4b8cc8a
Adding PR review owners to notifications sent to the Mattermost i18n-…
903df54 
…channel
Merge branch 'weblate_scripts' of github.com:ctlaltdieliet/i18n-wip i…
11be357 
…nto weblate_scripts
undo changes to double_languages.py
473a2ed
@ctlaltdieliet
Merge branch 'master' into weblate_scripts
15a8558
undo
9df1bda
Merge branch 'weblate_scripts' of github.com:ctlaltdieliet/i18n-wip i…
6b9b106 
…nto weblate_scripts
undo
bb7a7cc
fixing things
30124ee
working too late
9d900b9
adding devin.binnie
9373195
markdown adjustment
1b6ec13
replacing zef.hemel by pantelis.vratsalis
4cfb6d1
replacing zef.hemel by pantelis.vratsalis
17eab84
@ctlaltdieliet
Merge branch 'master' into weblate_scripts
1863fab
changing notification and adding notification state for double languages
b548d1a
Merge branch 'weblate_scripts' of github.com:ctlaltdieliet/i18n-wip i…
8d693b1 
…nto weblate_scripts
@ctlaltdieliet
Merge branch 'mattermost:master' into weblate_scripts
3622d88
adding reminder function of component remains locked for longer thn o…
e3093bb 
…ne week
@ctlaltdieliet
Merge branch 'master' into weblate_scripts
e005570
@ctlaltdieliet
Fix writing the locks everytime
8f4e63b
@ctlaltdieliet
Update weblate_locks_notify_community.py
084ab02
fixing not reading all shipped languages if more than 20
92d7b5c
fixing not reading all shipped languages if more than 20
62c15fc
@lieut-data lieut-data self-requested a review February 14, 2023 21:01
lieut-data
lieut-data reviewed Feb 14, 2023
View reviewed changes
Copy link
Member

@lieut-data lieut-data left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hi @ctlaltdieliet! @cwarnermm asked for help reviewing this change, but I'm wondering if it's still in a draft status given some debugging changes? Let me know and I'm happy to help move this forward :)

@ctlaltdieliet
Copy link
Contributor Author

Hi @lieut-data ,
thanks for the review. The scripts still contained indeed some debugging information. I removed the debugging output. Lazy programmers like me really benefit from reviews :)
Some background: these scripts run on a Raspberry Pi at my place.
I add the scripts to this repository so that it is documented and transparent what is happening and Mattermost is less reliant on a community member.

lieut-data
lieut-data requested changes Feb 15, 2023
View reviewed changes
Copy link
Member

@lieut-data lieut-data left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for that context, @ctlaltdieliet! I completely understand the debugging changes now :)

Just two thoughts below on the pagination of the weblate API, as it seems like it might not be working as expected. Hope this helps.

scripts/weblate/double_languages.py Outdated Show resolved Hide resolved
scripts/weblate/double_languages.py Outdated Show resolved Hide resolved
lieut-data
lieut-data approved these changes Feb 16, 2023
View reviewed changes
Copy link
Member

@lieut-data lieut-data left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lieut-data lieut-data lieut-data approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ctlaltdieliet @lieut-data