Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DOC-7565: Reply to messages page needs animated GIFs for mobile app workflows #7566

Merged
merged 6 commits into from
Nov 12, 2024

Conversation

Rutam21
Copy link
Contributor

@Rutam21 Rutam21 commented Nov 7, 2024

Summary

This PR adds visual workflows for the Mattermost mobile app tab on the Reply to messages page.

Ticket Link

Fixes #7565

  • This PR follows Mattermost Contributing Guidelines.
  • The changes are tested in a local docs build.

@mattermost-build
Copy link
Contributor

Hello @Rutam21,

Thanks for your pull request! A Core Committer will review your pull request soon. For code contributions, you can learn more about the review process here.

@Rutam21
Copy link
Contributor Author

Rutam21 commented Nov 7, 2024

@cwarnermm Please review and suggest changes, if any. Thanks.

@cwarnermm cwarnermm self-requested a review November 7, 2024 16:41
@cwarnermm cwarnermm added 2: Editor Review Requires review by an editor preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories labels Nov 7, 2024
Copy link

github-actions bot commented Nov 7, 2024

Newest code from Rutam21 has been published to preview environment for Git SHA b435d74

@cwarnermm
Copy link
Member

@Rutam21 - The image quality of these mobile images is considerably lower than others you've contributed recently. Is there a way to increase the image quality to avoid the checker-pattern effect when the image is displayed via docs?

Screenshot 2024-11-07 at 12 07 36 PM

@Rutam21
Copy link
Contributor Author

Rutam21 commented Nov 7, 2024

@cwarnermm I have updated the GIFs. Please check if the image quality looks okay now.

@cwarnermm cwarnermm added preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories and removed preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories labels Nov 8, 2024
Copy link

github-actions bot commented Nov 8, 2024

Newest code from Rutam21 has been published to preview environment for Git SHA 33d0c7b

@cwarnermm
Copy link
Member

@Rutam21 - In your latest commit, I noticed that you changed the :scale: value for the screenshots. That hasn't improved the image quality (expected). The scale attribute resizes the image, it doesn't affect image quality.

I recommend reviewing your capture tool configuration -- that's likely where the lower-res quality is coming from.

@Rutam21
Copy link
Contributor Author

Rutam21 commented Nov 8, 2024

@cwarnermm I have not only changed the scale but also updated the GIFs with totally newer ones. Please find the screenshot of the updated ones below. This is visible in the preview environment. Are you still seeing them pixelated or distorted?

Screenshot 2024-11-08 233748

@cwarnermm cwarnermm added preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories and removed preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories labels Nov 12, 2024
Copy link

Newest code from Rutam21 has been published to preview environment for Git SHA a690ce3

Copy link
Member

@cwarnermm cwarnermm left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks, @Rutam21!

@cwarnermm cwarnermm added 3: Reviews Complete All reviewers have approved the pull request and removed 2: Editor Review Requires review by an editor preview-environment Allow the preview environment to be generated for Pull Requests coming from fork repositories labels Nov 12, 2024
@cwarnermm cwarnermm merged commit f036593 into mattermost:master Nov 12, 2024
5 checks passed
@Rutam21 Rutam21 deleted the DOC-7565 branch November 12, 2024 14:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
3: Reviews Complete All reviewers have approved the pull request Contributor
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Reply to messages page needs animated GIFs for mobile app workflows
3 participants