-
Notifications
You must be signed in to change notification settings - Fork 582
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DOC-7526: Communicate a channel’s focus and scope page needs animated… #7527
Conversation
… GIFs for mobile app workflows
@cwarnermm Please review and suggest changes, if any. Thanks. @lindy65 Please add this to my queue for QA Testing once the reviews are complete. Thank you. |
Newest code from Rutam21 has been published to preview environment for Git SHA 260e1a7 |
Assigned to you for testing @Rutam21 👍 |
Newest code from Rutam21 has been published to preview environment for Git SHA 8bc3229 |
Newest code from Rutam21 has been published to preview environment for Git SHA ecc004b |
Newest code from Rutam21 has been published to preview environment for Git SHA 8c1a612 |
@cwarnermm I got the bug. This PR uses the image files added in this PR: #7525. Hence, those image files are missing from this preview branch. This should resolve itself after we merge that PR and try building another preview. |
Newest code from Rutam21 has been published to preview environment for Git SHA 8c1a612 |
Thanks, @Rutam21 for that heads-up! Splitting image files across PRs would definitely net poor results in previews. I've merged the related PR. Once published, I'll confirm it's working as expected, then come back to this PR. If previews still aren't working, I'll either pull the fork down locally OR may merge then fix. |
@cwarnermm Points noted. I will keep this in mind while raising the next PRs. However, the preview still seems to be broken but the changes work after the merge. Please find a screenshot of the local docs build attached. |
The shorter path through on this PR is to merge it and investigate/fix it in production. So that's what I'm going to do. |
Summary
This PR adds visual workflows for the Mattermost mobile app tab on the Communicate a channel’s focus and scope page
Ticket Link
Fixes #7526