Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Adds token whitelists and blacklists #229

Merged
merged 3 commits into from
Oct 24, 2023

Conversation

montekki
Copy link
Contributor

@montekki montekki commented Oct 10, 2023

Adds support for token whitelists and blacklists to configuration options. The logic is the following:

  • If none are configured the finalizer functions as it does now
  • If any are configured, then the whitelist takes priority over a blacklist since whitelist is supposed to be stricter.

This is the initial step in the direction of this feature; and this may be enough for opensourcing and production on mainnet2. Whenever this logic is to be expanded by token volumes or withdrawal failures counting, the queries would remain the same, just sources of parameters would be non-static.

The way this is currently supposed to work is this:

  1. As before the finalizer collects all withdrawals of all deployed tokens and their respective withdrawal parameters etc.
  2. There may be lists configured to white or blacklist some tokens, as such they will be respected.
  3. if in 2. some of the sets is changed with adding some tokens all prior withdrawals for these tokens will be finalized.

In other words, we still have all the history and in case of errors with configuration or such we will still be able to finalize everything we are interested in by changing confs.

@montekki montekki merged commit 8080708 into main Oct 24, 2023
5 checks passed
@montekki montekki deleted the fs-add-token-white-and-blacklists branch October 24, 2023 10:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants