Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix(api): batch fee input scaling for debug_traceCall #3344

Open
wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix(api): batch fee input scaling for debug_traceCall #3344

wants to merge 2 commits into from

Conversation

itegulov
Copy link
Contributor

@itegulov itegulov commented Nov 29, 2024 •
edited
Loading

What ❔

Changes the debug_traceCall handler to use gas price factor instead of plain gas factor.

Additionally removes entrypoints into get_batch_fee_input_scaled with default scaling factor (1.0)

Why ❔

Previously, debug_traceCall was using incorrect gas scaling factor

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).
  • Tests for the changes have been added / updated.
  • Documentation comments have been added / updated.
  • Code has been formatted via zkstack dev fmt and zkstack dev lint.

@itegulov itegulov requested a review from slowli November 29, 2024 06:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@slowli slowli Awaiting requested review from slowli

At least 1 approving review is required to merge this pull request.

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
1 participant
@itegulov