feat: Support stable compiler for VM (and some other crates) #3248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
popzxc
changed the title
EmilLuta
reviewed
Nov 22, 2024
| @@ -0,0 +1 @@ | |||
|
|
|||
There was a problem hiding this comment.
Is this empty file a mistake?
| circuit_sequencer_api_1_4_1.workspace = true | ||
| circuit_sequencer_api_1_4_2.workspace = true | ||
| circuit_sequencer_api_1_5_0.workspace = true | ||
| circuit_sequencer_api.workspace = true |
| circuit_setup_data.wits_hint, | ||
| &worker, | ||
| let mut data_source = self.keystore.load_keys_to_data_source()?; | ||
| let circuit_setup_data = generate_light_circuit_setup_data( |
There was a problem hiding this comment.
I'm not sure I follow logic here. Is this the rewrite from crypto side?
There was a problem hiding this comment.
Just copy-paste from Artyom's PR
| @@ -1,4 +1,4 @@ | |||
| use std::sync::Arc; | |||
| use std::{alloc::Global, sync::Arc}; | |||
There was a problem hiding this comment.
Makes me wonder, if we hardcode the Global allocator, why we bother to allow is a template arg?
There was a problem hiding this comment.
Just copy-paste from Artyom's PR
…pzxc-stable-rust (#3323) "Update generated Prover FRI GPU setup-data keys from branch popzxc-stable-rust"
# Conflicts: # prover/Cargo.lock
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tbd