-
Notifications
You must be signed in to change notification settings - Fork 2.1k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat(zkstack): Split chain and ecosystem layers #3199
Open
matias-gonz
wants to merge
62
commits into
main
Choose a base branch
from
matias/refactor-chain-commands
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 49 commits
Commits
Show all changes
62 commits
Select commit
Hold shift + click to select a range
f56e9c2
Migrate server to chain
matias-gonz 409e768
Migrate contract verifier to chain
matias-gonz 2d4f8fc
Migrate consensus to chain
matias-gonz ba8b707
fmt
matias-gonz 8d238d5
Fix consensus proto
matias-gonz 5b314a6
Fix consensus command
matias-gonz 8f7d9f7
Add ZkStackConfig enum
matias-gonz ca2f0e8
fmt
matias-gonz 8f046fd
Refactor deploy paymaster
matias-gonz 62e69be
Refactor chain commands
matias-gonz 06ddc2c
rollback consensus
matias-gonz 1b12e6e
Refactor chain consensus setup
matias-gonz c2f326c
Merge branch 'main' into matias/refactor-3-layered-chain
matias-gonz 49e971c
Merge branch 'main' of github.com:matter-labs/zksync-era into matias/…
matias-gonz cb00b8d
Update tests
matias-gonz c26c886
Merge branch 'main' into matias/refactor-chain-commands
matias-gonz 3252224
fmt
matias-gonz 17302bb
Merge branch 'matias/refactor-chain-commands' of github.com:matter-la…
matias-gonz e5978a4
fmt
matias-gonz 88c2e99
generate autocompletion
matias-gonz efed818
Merge branch 'main' into matias/refactor-chain-commands
matias-gonz 88bdf4d
lint autocomplete
matias-gonz b87969a
generate autocomplete
matias-gonz 142a327
lint
matias-gonz 95d82b1
Merge branch 'main' into matias/refactor-chain-commands
matias-gonz 281c158
Merge branch 'main' into matias/refactor-chain-commands
matias-gonz 6d94d1b
Fix ci
matias-gonz 942e335
Make contract_verifier:init:run async
matias-gonz 1a6f628
Remove use messages:self
matias-gonz f6fb8bf
Remove _zkstack.zsh
matias-gonz a01eea8
Load chain in chain:run and pass it to the next commands
matias-gonz 6c2f2b8
Merge branch 'main' into matias/refactor-chain-commands
matias-gonz 18403f1
Add ChainConfig::from_internal
matias-gonz bf1f8da
Rename ZkStackConfig::load_current_chain to current_chain
matias-gonz b2d7388
Add ZkStackConfig::ecosystem
matias-gonz 6406717
Make EcosystemConfig::from_file private
matias-gonz 2c5cf58
Make ChainConfigInternal::from_file private
matias-gonz f69f271
Make ChainConfig::from_internal private
matias-gonz d4632ef
Merge branch 'main' into matias/refactor-chain-commands
matias-gonz 0700795
Merge branch 'main' into matias/refactor-chain-commands
matias-gonz d394301
Merge branch 'main' of github.com:matter-labs/zksync-era into matias/…
matias-gonz df2cc9e
fmt
matias-gonz e792afe
Add autocompletion files
matias-gonz c55067c
Add zsh autocomplete file
matias-gonz 5b53a64
Merge branch 'main' into matias/refactor-chain-commands
matias-gonz 00d7649
Fix ci
matias-gonz b3773bb
Fix contract-verifier ci
matias-gonz f73f399
Fix contract-verifier ci
matias-gonz 60054e7
Merge branch 'main' into matias/refactor-chain-commands
matias-gonz 850efc7
Merge branch 'main' of github.com:matter-labs/zksync-era into matias/…
matias-gonz a43a770
Merge branch 'main' into matias/refactor-chain-commands
matias-gonz 90fb3cc
Merge branch 'main' into matias/refactor-chain-commands
matias-gonz b15b532
Merge branch 'main' into matias/refactor-chain-commands
matias-gonz 19c46c6
feat(zk_toolbox): Make chain create independent from ecosystem (#3210)
matias-gonz d6c3446
feat(zk_toolbox): Make chain init independent from ecosystem (#3231)
matias-gonz 9f9ab7d
Merge branch 'main' into matias/refactor-chain-commands
matias-gonz cfffd44
Fix conflicts
matias-gonz 8256433
feat(zkstack): Run containers with either chain or ecosystem (#3345)
matias-gonz 8584649
fix(zkstack): Fix duplicated chain layer (#3348)
matias-gonz feaae79
Rename ecosystem_wallets_path
matias-gonz 6126695
Lint
matias-gonz 0a9a2f5
Merge branch 'main' into matias/refactor-chain-commands
matias-gonz File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,17 @@ | ||
use std::path::PathBuf; | ||
|
||
use xshell::Shell; | ||
|
||
// Find file in all parents repository and return necessary path or an empty error if nothing has been found | ||
pub fn find_file(shell: &Shell, path_buf: PathBuf, file_name: &str) -> Result<PathBuf, ()> { | ||
let _dir = shell.push_dir(path_buf); | ||
if shell.path_exists(file_name) { | ||
Ok(shell.current_dir()) | ||
} else { | ||
let current_dir = shell.current_dir(); | ||
let Some(path) = current_dir.parent() else { | ||
return Err(()); | ||
}; | ||
find_file(shell, path.to_path_buf(), file_name) | ||
} | ||
} |
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
let's remove
pub
frompub fn from_file(shell: &Shell) -> Result<Self, EcosystemConfigFromFileError>
In this case it'd be impossible to deserialize config outside ZkstackConfig
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
6406717