Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update zk_evm dependency #72

Merged

Conversation

slowli
Copy link
Contributor

@slowli slowli commented Sep 25, 2024

What ❔

Updates the zk_evm dependency to the latest published version.

Why ❔

It is impossible to publish the zksync_vm2 crate which depends on a git revision w/o a version specified.

Checklist

  • PR title corresponds to the body of PR (we generate changelog entries from PRs).

@slowli
Copy link
Contributor Author

slowli commented Sep 25, 2024

@joonazan AFAIU, the 0.150.5 release incorporates the fix you've submitted. Please double-check.

@slowli slowli marked this pull request as ready for review September 25, 2024 14:42
@slowli slowli requested a review from joonazan as a code owner September 25, 2024 14:42
Copy link
Contributor

@joonazan joonazan left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Yes, seems to incorporate my fix as the older code for 1.5 checks normalized_preimage instead of the header.

@joonazan joonazan merged commit 24de402 into master Sep 25, 2024
8 checks passed
@joonazan joonazan deleted the aov-pla-1027-brush-up-vm2-repo-for-publishing-fix-zkevm branch September 25, 2024 17:26
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants