Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: updates deps and refactor for evm #25

Merged
merged 9 commits into from
Nov 14, 2024
Merged

chore: updates deps and refactor for evm #25

merged 9 commits into from
Nov 14, 2024

Conversation

uF4No
Copy link
Collaborator

@uF4No uF4No commented Oct 31, 2024 •
edited
Loading

What

  • Updates dependencies: ethers 6.x.x and hardhat-zksync 1.2.0
  • Refactor deployment scripts to follow EVM-like standards and not use Deployer class specific from zksync-ethers
  • Refactor tests to follow EVM-like standards
  • Runs tests vs era-test-node integrated on hardhat-zksync

Why

  • Old deps
  • Codebase was following old practices with a lot of zksync-specific classes and APIs
  • New plugins allowed for EVM-like tests and deployment scripts

dutterbutter
dutterbutter requested changes Oct 31, 2024
View reviewed changes
Copy link
Contributor

@dutterbutter dutterbutter left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Few small things, thank you!

contracts/test/allowlist.test.ts Outdated Show resolved Hide resolved
.github/workflows/test.yml Outdated Show resolved Hide resolved
contracts/deploy/allowListPaymaster.ts Show resolved Hide resolved
contracts/deploy/allowListPaymaster.ts Show resolved Hide resolved
contracts/deploy/allowListPaymaster.ts Outdated Show resolved Hide resolved
contracts/deploy/gaslessPaymaster.ts Outdated Show resolved Hide resolved
contracts/deploy/greeter.ts Outdated Show resolved Hide resolved
contracts/deploy/timeBasedPaymaster.ts Outdated Show resolved Hide resolved
contracts/hardhat.config.ts Outdated Show resolved Hide resolved
contracts/hardhat.config.ts Outdated Show resolved Hide resolved
@uF4No uF4No merged commit f596cdd into main Nov 14, 2024
1 check passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@MexicanAce MexicanAce MexicanAce left review comments

@dutterbutter dutterbutter dutterbutter approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@uF4No @MexicanAce @dutterbutter