-
Notifications
You must be signed in to change notification settings - Fork 348
Commit
This commit does not belong to any branch on this repository, and may belong to a fork outside of the repository.
Showing
4 changed files
with
4 additions
and
40 deletions.
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
|
@@ -9,13 +9,12 @@ import {ETH_TOKEN_ADDRESS} from "../common/Config.sol"; | |
import {IERC20} from "@openzeppelin/contracts-v4/token/ERC20/IERC20.sol"; | ||
import {Ownable2StepUpgradeable} from "@openzeppelin/contracts-upgradeable-v4/access/Ownable2StepUpgradeable.sol"; | ||
import {IGetters} from "../state-transition/chain-interfaces/IGetters.sol"; | ||
import {ReentrancyGuard} from "../common/ReentrancyGuard.sol"; | ||
import {SafeERC20} from "@openzeppelin/contracts-v4/token/ERC20/utils/SafeERC20.sol"; | ||
|
||
/// @author Matter Labs | ||
/// @custom:security-contact [email protected] | ||
/// @dev ChainRegistrar serves as the main point for chain registration. | ||
contract ChainRegistrar is Ownable2StepUpgradeable, ReentrancyGuard { | ||
contract ChainRegistrar is Ownable2StepUpgradeable { | ||
using SafeERC20 for IERC20; | ||
/// @notice Address that will be used for deploying l2 contracts | ||
address public l2Deployer; | ||
|
@@ -27,21 +26,14 @@ contract ChainRegistrar is Ownable2StepUpgradeable, ReentrancyGuard { | |
/// Proposal for chain registration | ||
mapping(address => mapping(uint256 => ChainConfig)) public proposedChains; | ||
|
||
error ProposalNotFound(); | ||
error BaseTokenTransferFailed(); | ||
error ChainIsAlreadyDeployed(); | ||
error ChainIsNotYetDeployed(); | ||
error BridgeIsNotRegistered(); | ||
|
||
/// @notice new chain is deployed | ||
event NewChainDeployed(uint256 indexed chainId, address author, address diamondProxy, address chainAdmin); | ||
|
||
/// @notice new chain is proposed to register | ||
event NewChainRegistrationProposal(uint256 indexed chainId, address author); | ||
|
||
/// @notice Shared bridge is registered on l2 | ||
event SharedBridgeRegistered(uint256 indexed chainId, address l2Address); | ||
|
||
/// @notice L2 Deployer has changed | ||
event L2DeployerChanged(address newDeployer); | ||
|
||
|
@@ -75,7 +67,7 @@ contract ChainRegistrar is Ownable2StepUpgradeable, ReentrancyGuard { | |
} | ||
|
||
// @dev Initialize the contract | ||
function initialize(address _bridgehub, address _l2Deployer, address _owner) public reentrancyGuardInitializer { | ||
function initialize(address _bridgehub, address _l2Deployer, address _owner) public { | ||
bridgehub = IBridgehub(_bridgehub); | ||
l2Deployer = _l2Deployer; | ||
_transferOwnership(_owner); | ||
|
@@ -96,7 +88,7 @@ contract ChainRegistrar is Ownable2StepUpgradeable, ReentrancyGuard { | |
address _tokenMultiplierSetter, | ||
uint128 _gasPriceMultiplierNominator, | ||
uint128 _gasPriceMultiplierDenominator | ||
) public { | ||
) external { | ||
ChainConfig memory config = ChainConfig({ | ||
chainId: _chainId, | ||
pubdataPricingMode: _pubdataPricingMode, | ||
|
@@ -133,10 +125,6 @@ contract ChainRegistrar is Ownable2StepUpgradeable, ReentrancyGuard { | |
emit L2DeployerChanged(l2Deployer); | ||
} | ||
|
||
function getChainConfig(address _author, uint256 _chainId) public view returns (ChainConfig memory) { | ||
return proposedChains[_author][_chainId]; | ||
} | ||
|
||
// @dev Get data about the chain that has been fully deployed | ||
function getRegisteredChainConfig(uint256 _chainId) public view returns (RegisteredChainConfig memory) { | ||
address stm = bridgehub.stateTransitionManager(_chainId); | ||
|
@@ -160,19 +148,4 @@ contract ChainRegistrar is Ownable2StepUpgradeable, ReentrancyGuard { | |
}); | ||
return config; | ||
} | ||
|
||
// @dev Mark chain as registered. Emit necessary events for spinning up the chain server | ||
function setChainAsRegistered(address _author, uint256 _chainId) public onlyOwner nonReentrant { | ||
ChainConfig memory config = proposedChains[_author][_chainId]; | ||
if (config.chainId == 0) { | ||
revert ProposalNotFound(); | ||
} | ||
|
||
RegisteredChainConfig memory deployedConfig = getRegisteredChainConfig(_chainId); | ||
|
||
// Matter Labs team set the pending admin to the chain admin and now governor of the chain must accept ownership | ||
emit NewChainDeployed(_chainId, _author, deployedConfig.diamondProxy, deployedConfig.pendingChainAdmin); | ||
emit SharedBridgeRegistered(_chainId, deployedConfig.l2BridgeAddress); | ||
deployedChains[_author][_chainId] = true; | ||
} | ||
} |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters