Skip to content
This repository has been archived by the owner on Apr 26, 2024. It is now read-only.

Mention how to redirect the Jaeger traces to a specific Jaeger instance #16531

Merged
merged 4 commits into from
Oct 23, 2023

Conversation

MTRNord
Copy link
Contributor

@MTRNord MTRNord commented Oct 20, 2023

This adds a small note to the opentracing docs when your jaeger is not on localhost next to synapse. For example in a Kubernetes env.

Signed-Off-By: Marcel Radzio [email protected]

Pull Request Checklist

  • Pull request is based on the develop branch
  • Pull request includes a changelog file. The entry should:
    • Be a short description of your change which makes sense to users. "Fixed a bug that prevented receiving messages from other servers." instead of "Moved X method from EventStore to EventWorkerStore.".
    • Use markdown where necessary, mostly for code blocks.
    • End with either a period (.) or an exclamation mark (!).
    • Start with a capital letter.
    • Feel free to credit yourself, by adding a sentence "Contributed by @github_username." or "Contributed by [Your Name]." to the end of the entry.
  • Pull request includes a sign off
  • Code style is correct
    (run the linters)

docs/opentracing.md Outdated Show resolved Hide resolved
Copy link
Contributor

@DMRobertson DMRobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

See https://github.com/matrix-org/synapse/pull/16531/files#r1368501309. Would like to see moving the sentence at least, everything else is nice-to-have.

docs/opentracing.md Outdated Show resolved Hide resolved
Copy link
Contributor

@DMRobertson DMRobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Many thanks!

@DMRobertson DMRobertson enabled auto-merge (squash) October 23, 2023 11:54
@DMRobertson DMRobertson merged commit 3bcb6a0 into matrix-org:develop Oct 23, 2023
31 checks passed
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants