Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Include redundant members in most timeline filters #4329

Open
wants to merge 4 commits into
base: develop
Choose a base branch
from
Open

Include redundant members in most timeline filters #4329

wants to merge 4 commits into from

Commits on Jul 25, 2024

  1. Include redundant members in most timeline filters 

    Synapse never tries to avoid redundant members anyway, so it's hard to ensure that it works correctly (https://github.com/element-hq/synapse/blob/568051c0f07393b786b9d813a1db53dd332c9fc2/synapse/handlers/pagination.py#L639)
It also seems like it would be difficult when the "Show current profile picture and name for users in message history" option is turned off

Conduwuit and Dendrite do attempt to remove redundant members, and it seems to cause some problems, so this commit tells them to include redundant members

Similar to element-hq/element-web#7417, which is also why there might still be missing profiles in rare cases after this

Signed-off-by: morguldir <[email protected]>
    @morguldir
    morguldir committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    1c2786a View commit details
    Browse the repository at this point in the history

  2. Lint 

    Signed-off-by: morguldir <[email protected]>
    @morguldir
    morguldir committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    f6683f0 View commit details
    Browse the repository at this point in the history

  3. Add integration test for missing sender profile edge case

    @morguldir
    morguldir committed Jul 25, 2024
    Configuration menu
    Copy the full SHA
    25608e0 View commit details
    Browse the repository at this point in the history

Commits on Jul 30, 2024

  1. Merge branch 'develop' into redundant-member-state-scrollback

    @t3chguy
    t3chguy authored Jul 30, 2024
    Configuration menu
    Copy the full SHA
    980b256 View commit details
    Browse the repository at this point in the history