Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[WIP] Rewrite receipt handling #3873

Draft
wants to merge 33 commits into
base: develop
Choose a base branch
from
Draft

[WIP] Rewrite receipt handling #3873

wants to merge 33 commits into from

Commits on Oct 31, 2023

  1. Ignore receipts pointing at missing or invalid events

    @andybalaam
    andybalaam committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    6e9a3c4 View commit details
    Browse the repository at this point in the history

  2. Remove extra whitespace from log message

    @andybalaam
    andybalaam committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    5cfe82e View commit details
    Browse the repository at this point in the history

  3. Unit tests for ignoring invalid receipts

    @andybalaam
    andybalaam committed Oct 31, 2023
    Configuration menu
    Copy the full SHA
    f542315 View commit details
    Browse the repository at this point in the history

Commits on Nov 1, 2023

  1. Improve comments around getEventReadUpTo

    @andybalaam
    andybalaam committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    9fa5374 View commit details
    Browse the repository at this point in the history

  2. Re-instate second param to compareEventOrdering in test 

    Co-authored-by: Richard van der Hoff <[email protected]>
    @andybalaam @richvdh
    andybalaam and richvdh authored Nov 1, 2023
    Configuration menu
    Copy the full SHA
    9060e0e View commit details
    Browse the repository at this point in the history

  3. Further improve comments around getEventReadUpTo

    @andybalaam
    andybalaam committed Nov 1, 2023
    Configuration menu
    Copy the full SHA
    3686d61 View commit details
    Browse the repository at this point in the history

Commits on Nov 3, 2023

  1. WIP

    @andybalaam
    andybalaam committed Nov 3, 2023
    Configuration menu
    Copy the full SHA
    4ee0fba View commit details
    Browse the repository at this point in the history

Commits on Nov 7, 2023

  1. Fix typo in thread test

    @andybalaam
    andybalaam committed Nov 7, 2023
    Configuration menu
    Copy the full SHA
    ad79e97 View commit details
    Browse the repository at this point in the history

Commits on Nov 9, 2023

  1. Merge branch 'develop' into andybalaam/rewrite-receipts

    @andybalaam
    andybalaam committed Nov 9, 2023
    Configuration menu
    Copy the full SHA
    43ad085 View commit details
    Browse the repository at this point in the history

Commits on Nov 10, 2023

  1. Merge branch 'develop' into andybalaam/rewrite-receipts

    @andybalaam
    andybalaam committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    5bd2444 View commit details
    Browse the repository at this point in the history

  2. Remove extraneous import

    @andybalaam
    andybalaam committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    26598e1 View commit details
    Browse the repository at this point in the history

  3. First ideas of tests for RoomReceipts

    @andybalaam
    andybalaam committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    2bf53df View commit details
    Browse the repository at this point in the history

  4. More tests for RoomReceipts

    @andybalaam
    andybalaam committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    c6b0a89 View commit details
    Browse the repository at this point in the history

  5. More tests and a fix because unit tests rule

    @andybalaam
    andybalaam committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    684b831 View commit details
    Browse the repository at this point in the history

  6. Add a test for mixing threaded and unthreaded receipts

    @andybalaam
    andybalaam committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    045e169 View commit details
    Browse the repository at this point in the history

  7. Break out user-sent-last-message logic into a function

    @andybalaam
    andybalaam committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    fce2d98 View commit details
    Browse the repository at this point in the history

  8. Fix incorrect failing test

    @andybalaam
    andybalaam committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    b61bc69 View commit details
    Browse the repository at this point in the history

  9. Enhance mock to allow tests to pass with new cod

    @andybalaam
    andybalaam committed Nov 10, 2023
    Configuration menu
    Copy the full SHA
    b88706e View commit details
    Browse the repository at this point in the history

Commits on Nov 13, 2023

  1. Add a test for two events in old timelines

    @andybalaam
    andybalaam committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    4c04a7b View commit details
    Browse the repository at this point in the history

  2. Add a test for events received after we sent one

    @andybalaam
    andybalaam committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    d1cb13d View commit details
    Browse the repository at this point in the history

  3. Merge branch 'develop' into andybalaam/rewrite-receipts

    @andybalaam
    andybalaam committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    037b6b7 View commit details
    Browse the repository at this point in the history

  4. Rename compare-event-ordering

    @andybalaam
    andybalaam committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    5e7dfd3 View commit details
    Browse the repository at this point in the history

  5. Merge branch 'develop' into andybalaam/rewrite-receipts

    @andybalaam
    andybalaam committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    b236ebb View commit details
    Browse the repository at this point in the history

  6. Make compareEventOrdering use -1, 0 or 1 (or null) exclusively

    @andybalaam
    andybalaam committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    7aa570e View commit details
    Browse the repository at this point in the history

  7. Re-instate methods I deleted from public interfaces

    @andybalaam
    andybalaam committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    59f3214 View commit details
    Browse the repository at this point in the history

  8. Update comment to remove unexpected case

    @andybalaam
    andybalaam committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    7452baa View commit details
    Browse the repository at this point in the history

  9. Improve comments about code to delete

    @andybalaam
    andybalaam committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    f6d9cd8 View commit details
    Browse the repository at this point in the history

  10. Merge branch 'develop' into andybalaam/rewrite-receipts

    @andybalaam
    andybalaam committed Nov 13, 2023
    Configuration menu
    Copy the full SHA
    2d10141 View commit details
    Browse the repository at this point in the history

Commits on Nov 15, 2023

  1. Merge branch 'develop' into andybalaam/rewrite-receipts

    @andybalaam
    andybalaam committed Nov 15, 2023
    Configuration menu
    Copy the full SHA
    5a0fbbd View commit details
    Browse the repository at this point in the history

Commits on Nov 16, 2023

  1. BREAKS UNIT TESTS use correct thread when synthesizing receipts

    @andybalaam
    andybalaam committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    56875a7 View commit details
    Browse the repository at this point in the history

  2. Merge branch 'develop' into andybalaam/rewrite-receipts

    @andybalaam
    andybalaam committed Nov 16, 2023
    Configuration menu
    Copy the full SHA
    5b355d5 View commit details
    Browse the repository at this point in the history

Commits on Nov 17, 2023

  1. Fix incorrect thread ID in read-receipt tests

    @andybalaam
    andybalaam committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    0861f6b View commit details
    Browse the repository at this point in the history

  2. Fix unit tests to reflect the fix putting synthetic receipts in the r… 

    …ight thread
    @andybalaam
    andybalaam committed Nov 17, 2023
    Configuration menu
    Copy the full SHA
    612e35e View commit details
    Browse the repository at this point in the history