Add MinimumPowerLevel option to clients #357
Conversation
clients/clients.go
Outdated
| return | ||
| } | ||
| var pl = plContent.Users[event.Sender.String()] | ||
| if pl == 0 { |
There was a problem hiding this comment.
Technically this is wrong - the user could have a PL of 0 set explicitly, and afaict in that case the PL should not revert to UsersDefault. It should revert to UsersDefault if the user has not explicitly been set any power level.
However I'm not sure in this context does plContent.Users have all users or just those who have a PL set? If the latter, wont this whole thing crash since there will be nothing in the map for that user?
There was a problem hiding this comment.
I did some learning of go, and doing aMap["foo"] will return two values. The first is the value, and the second is whether the value existed in the map.
So in this case, I can do var pl, userExists and if userExists is false, we fall back to the default PL.
This change adds an option to specify the minimum PL level of the inviting user for the bot to remain joined to the room. This change will only affect services which accept invites to rooms, so services like GitHub need a different change.