Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix param name in (Must)CreateRoom #679

Merged
merged 1 commit into from
Oct 17, 2023
Merged

Conversation

DMRobertson
Copy link
Contributor

the given map is the JSON body of the /createRoom request, NOT the "creation content" that the spec speaks of (i.e. the content of the m.room.create event.)

the given map is the JSON body of the /createRoom request, NOT the
"creation content" that the spec speaks of (i.e. the content of the
m.room.create event.)
@DMRobertson DMRobertson requested review from a team as code owners October 17, 2023 16:16
Copy link
Member

@clokep clokep left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I think the synapse failure is a flake?

@DMRobertson
Copy link
Contributor Author

That's my assumption too.

@DMRobertson DMRobertson merged commit fb28fb4 into main Oct 17, 2023
3 of 4 checks passed
@DMRobertson DMRobertson deleted the dmr/createroom-param-name branch October 17, 2023 16:50
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants