Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove msc build tags. Add msc packages. #666

Merged
merged 3 commits into from
Oct 12, 2023
Merged

Remove msc build tags. Add msc packages. #666

merged 3 commits into from
Oct 12, 2023

Conversation

kegsay
Copy link
Member

@kegsay kegsay commented Oct 10, 2023

This adds more parallelism as a side-effect.

This adds more parallelism as a side-effect.
@kegsay kegsay requested review from a team as code owners October 10, 2023 09:50
Copy link
Contributor

@DMRobertson DMRobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is this going to need changes to https://github.com/matrix-org/synapse/blob/6d81aec09febe86532235141e84c4ea0b3f56049/scripts-dev/complement.sh#L217? Are there other places in Synapse we'll need to change? Similarly for dendrite

@kegsay
Copy link
Member Author

kegsay commented Oct 10, 2023

Yes.

Copy link
Contributor

@DMRobertson DMRobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM but it'd be very handy if you can do the Synapse+Dendrite changes too. (Though FWIW Synapse's develop is failing on particular complement test RN)

kegsay added a commit to matrix-org/dendrite that referenced this pull request Oct 11, 2023
@kegsay kegsay merged commit 6732db1 into main Oct 12, 2023
4 checks passed
@kegsay kegsay deleted the kegan/no-msc-tags branch October 12, 2023 10:33
kegsay added a commit to matrix-org/synapse that referenced this pull request Oct 12, 2023
* Update complement.sh to match new public API shape

Sister PR to matrix-org/complement#666

Context: matrix-org/complement#654 (comment)

* Changelog

* Pedantry

* Run complement plz
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants