-
Notifications
You must be signed in to change notification settings - Fork 52
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Remove msc build tags. Add msc packages. #666
Conversation
This adds more parallelism as a side-effect.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Is this going to need changes to https://github.com/matrix-org/synapse/blob/6d81aec09febe86532235141e84c4ea0b3f56049/scripts-dev/complement.sh#L217? Are there other places in Synapse we'll need to change? Similarly for dendrite
Yes. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM but it'd be very handy if you can do the Synapse+Dendrite changes too. (Though FWIW Synapse's develop is failing on particular complement test RN)
* Update complement.sh to match new public API shape Sister PR to matrix-org/complement#666 Context: matrix-org/complement#654 (comment) * Changelog * Pedantry * Run complement plz
This adds more parallelism as a side-effect.