Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add CSAPI.Must... functions #665

Merged
merged 10 commits into from
Oct 9, 2023
Merged

Add CSAPI.Must... functions #665

merged 10 commits into from
Oct 9, 2023

Conversation

kegsay
Copy link
Member

@kegsay kegsay commented Oct 9, 2023

Similar to the should package, this enables helper functions to be used to assert failures.

@kegsay kegsay requested review from a team as code owners October 9, 2023 14:00
DMRobertson
DMRobertson reviewed Oct 9, 2023
View reviewed changes
client/sync.go Outdated Show resolved Hide resolved
DMRobertson
DMRobertson reviewed Oct 9, 2023
View reviewed changes
client/client.go Outdated Show resolved Hide resolved
DMRobertson
DMRobertson reviewed Oct 9, 2023
View reviewed changes
client/client.go Outdated Show resolved Hide resolved
DMRobertson
DMRobertson approved these changes Oct 9, 2023
View reviewed changes
Copy link
Contributor

@DMRobertson DMRobertson left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

No huge objections but I have left nitpicks.

@kegsay kegsay merged commit 5263cfd into main Oct 9, 2023
4 checks passed
@kegsay kegsay deleted the kegan/client-should branch October 9, 2023 18:05
DMRobertson pushed a commit that referenced this pull request Oct 12, 2023
Fix MSC3890 tests using wrong CSAPI helper
c0c774a 
Regressed in #665.
@DMRobertson DMRobertson mentioned this pull request Oct 12, 2023
Merged
kegsay pushed a commit that referenced this pull request Oct 12, 2023
Fix MSC3890 tests using wrong CSAPI helper (#670)
b2863ec 
* Fix MSC3890 tests using wrong CSAPI helper

Regressed in #665.

* Signposts in MSC3890 tests
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@DMRobertson DMRobertson DMRobertson approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kegsay @DMRobertson