Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Move must and match packages out of internal; add generic must functions #661

Merged
merged 8 commits into from
Oct 5, 2023
Merged

Move must and match packages out of internal; add generic must functions #661

merged 8 commits into from
Oct 5, 2023

Conversation

kegsay
Copy link
Member

@kegsay kegsay commented Oct 4, 2023 •
edited
Loading

  • Make must and match public.
  • Add generic functions to must package, including new functions ContainSubset and NotContainSubset. Generic functions now mean EqualStr is renamed Equal.
  • must functions now typically accept gjson.Result and not byte slices.
  • JSON matchers now work with gjson.Result and not byte slices.
  • Tidy up tests to use more matchers than boilerplate.

@kegsay kegsay requested review from a team as code owners October 4, 2023 16:48
@kegsay kegsay changed the title WIP: Move must and match packages out of internal; add generic must functions Move must and match packages out of internal; add generic must functions Oct 5, 2023
@kegsay kegsay merged commit 9e57f77 into main Oct 5, 2023
4 checks passed
@kegsay kegsay deleted the kegan/must-match branch October 5, 2023 16:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@S7evinK S7evinK S7evinK approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kegsay @S7evinK